Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1807156-heap-use-after-free into lp:widelands

2019-03-05 Thread Klaus Halfmann
OK merged trunk. I get some ../src/wlapplication.cc:1476:30: warning: unused exception parameter 'e' [-Wunused-exception-parameter] } catch (const FileError& e) { will now use a debugger to poke into that code. -- https://code.launchpad.net/~widelands-dev/widelands/bug-1807156-heap-use

[Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/queued_emails into lp:widelands-website

2019-03-05 Thread kaputtnik
kaputtnik has proposed merging lp:~widelands-dev/widelands-website/queued_emails into lp:widelands-website. Commit message: Make use of a global setting to queue emails or not Requested reviews: Widelands Developers (widelands-dev) For more details, see: https://code.launchpad.net/~widelands-

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/frisian_music into lp:widelands

2019-03-05 Thread GunChleoc
It would have been nice to have the track's title in the commit message - now I'll have to dig into it when creating the changelog ;) -- https://code.launchpad.net/~widelands-dev/widelands/frisian_music/+merge/350429 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widela

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1807156-heap-use-after-free into lp:widelands

2019-03-05 Thread GunChleoc
Please do not report unrelated issues in merge requests - it makes the merge request noisy with unrelated discussions. Create a bug for it ;) I have fixed this one directly in trunk, thanks for reporting! -- https://code.launchpad.net/~widelands-dev/widelands/bug-1807156-heap-use-after-free/+mer

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/queued_emails into lp:widelands-website

2019-03-05 Thread GunChleoc
Review: Approve LGTM -- https://code.launchpad.net/~widelands-dev/widelands-website/queued_emails/+merge/363951 Your team Widelands Developers is subscribed to branch lp:widelands-website. ___ Mailing list: https://launchpad.net/~widelands-dev Post to

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1807156-heap-use-after-free into lp:widelands

2019-03-05 Thread Klaus Halfmann
Review: Needs Information OK, his is te code that will (new in R20) add the Helpbutton so the correct helpwindow for the building in progress will be shown. _parent is the same as igbase() which is used at the very start of the function, so I have no idea how this should be come null? Teh origi

[Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/queued_emails into lp:widelands-website

2019-03-05 Thread noreply
The proposal to merge lp:~widelands-dev/widelands-website/queued_emails into lp:widelands-website has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~widelands-dev/widelands-website/queued_emails/+merge/363951 -- Your team Widelands Developers

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/queued_emails into lp:widelands-website

2019-03-05 Thread kaputtnik
Thanks :-) -- https://code.launchpad.net/~widelands-dev/widelands-website/queued_emails/+merge/363951 Your team Widelands Developers is subscribed to branch lp:widelands-website. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widel

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1807156-heap-use-after-free into lp:widelands

2019-03-05 Thread Klaus Halfmann
I quick game for some 40 minutes, found nothing, will try to produce this in some coop game perhaps. -- https://code.launchpad.net/~widelands-dev/widelands/bug-1807156-heap-use-after-free/+merge/363584 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1807156-