Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1817664-overlooping-eva_fail into lp:widelands

2019-02-27 Thread hessenfarmer
travis fails due to sphinx not happy. should be fixed after merging trunk -- https://code.launchpad.net/~widelands-dev/widelands/bug-1817664-overlooping-eva_fail/+merge/363679 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1817664-overlooping-eva_fail. __

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1817664-overlooping-eva_fail into lp:widelands

2019-02-27 Thread bunnybot
Refusing to merge, since Travis is not green. Use @bunnybot merge force for merging anyways. Travis build 4531. State: failed. Details: https://travis-ci.org/widelands/widelands/builds/499122948. -- https://code.launchpad.net/~widelands-dev/widelands/bug-1817664-overlooping-eva_fail/+merge/3636

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1817664-overlooping-eva_fail into lp:widelands

2019-02-27 Thread Benedikt Straub
Merged trunk @bunnybot merge -- https://code.launchpad.net/~widelands-dev/widelands/bug-1817664-overlooping-eva_fail/+merge/363679 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1817664-overlooping-eva_fail. ___

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1817686-SDL-pixel-format into lp:widelands

2019-02-27 Thread GunChleoc
GunChleoc has proposed merging lp:~widelands-dev/widelands/bug-1817686-SDL-pixel-format into lp:widelands. Commit message: Fail with SDL messagebox if SDL_BYTESPERPIXEL != 4 Requested reviews: Widelands Developers (widelands-dev) Related bugs: Bug #1817686 in widelands: "Assert fail in Graph

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1817686-SDL-pixel-format into lp:widelands

2019-02-27 Thread Benedikt Straub
Tested it. The log says »ERROR: Wrong SDL_BYTESPERPIXEL, expected 4 but got 1« as expected. But no message box appears, the program exits immediately. By the way, the assert could be removed now, right? Since the triggering failure is now caught beforehand. -- https://code.launchpad.net/~widel

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1817686-SDL-pixel-format into lp:widelands

2019-02-27 Thread GunChleoc
I guess the driver is too messed up to even display the message box then. I have now made the log message identical to the dialog message and removed the assert. -- https://code.launchpad.net/~widelands-dev/widelands/bug-1817686-SDL-pixel-format/+merge/363729 Your team Widelands Developers is re

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1817686-SDL-pixel-format into lp:widelands

2019-02-27 Thread Benedikt Straub
Review: Approve It´s a perfectly normal built-in Intel graphics card (VGA compatible controller, Atom Processor Z36xxx/Z37xxx Series Graphics & Display) with default drivers – no reason why it should behave like that, especially in such a random way. It always worked before… The code looks goo

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1817686-SDL-pixel-format into lp:widelands

2019-02-27 Thread GunChleoc
Thanks for the review and testing @bunnybot merge -- https://code.launchpad.net/~widelands-dev/widelands/bug-1817686-SDL-pixel-format/+merge/363729 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1817686-SDL-pixel-format. __

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1817686-SDL-pixel-format into lp:widelands

2019-02-27 Thread kaputtnik
> built-in Intel graphics card I should had bet for this :-D There were several problems with this graphics card in the past. Glad it's working for you now. -- https://code.launchpad.net/~widelands-dev/widelands/bug-1817686-SDL-pixel-format/+merge/363729 Your team Widelands Developers is subscr

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1817664-overlooping-eva_fail into lp:widelands

2019-02-27 Thread bunnybot
Continuous integration builds have changed state: Travis build 4533. State: passed. Details: https://travis-ci.org/widelands/widelands/builds/499220518. Appveyor build 4320. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_bug_181766

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1817664-overlooping-eva_fail into lp:widelands

2019-02-27 Thread noreply
The proposal to merge lp:~widelands-dev/widelands/bug-1817664-overlooping-eva_fail into lp:widelands has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~widelands-dev/widelands/bug-1817664-overlooping-eva_fail/+merge/363679 -- Your team Widel

[Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/pybb_cleanup into lp:widelands-website

2019-02-27 Thread kaputtnik
kaputtnik has proposed merging lp:~widelands-dev/widelands-website/pybb_cleanup into lp:widelands-website. Requested reviews: Widelands Developers (widelands-dev) For more details, see: https://code.launchpad.net/~widelands-dev/widelands-website/pybb_cleanup/+merge/363742 A big cleanup on pyb

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1817686-SDL-pixel-format into lp:widelands

2019-02-27 Thread bunnybot
Continuous integration builds have changed state: Travis build 4535. State: errored. Details: https://travis-ci.org/widelands/widelands/builds/499382080. Appveyor build 4322. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_bug_18176

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1817686-SDL-pixel-format into lp:widelands

2019-02-27 Thread bunnybot
Refusing to merge, since Travis is not green. Use @bunnybot merge force for merging anyways. Travis build 4535. State: errored. Details: https://travis-ci.org/widelands/widelands/builds/499382080. -- https://code.launchpad.net/~widelands-dev/widelands/bug-1817686-SDL-pixel-format/+merge/363729

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1796364-blinking-buildings into lp:widelands

2019-02-27 Thread bunnybot
Continuous integration builds have changed state: Travis build 4536. State: errored. Details: https://travis-ci.org/widelands/widelands/builds/499415843. Appveyor build 4323. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_bug_17963

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/pybb_cleanup into lp:widelands-website

2019-02-27 Thread GunChleoc
Looks good to me. Can you spin up the alpha site for some testing? -- https://code.launchpad.net/~widelands-dev/widelands-website/pybb_cleanup/+merge/363742 Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands-website/pybb_cleanup into lp:widelan

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1817686-SDL-pixel-format into lp:widelands

2019-02-27 Thread hessenfarmer
travis failure is transient. (apt-get failed) @bunnybot merge force -- https://code.launchpad.net/~widelands-dev/widelands/bug-1817686-SDL-pixel-format/+merge/363729 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1817686-SDL-pixel-format. ___

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1796364-blinking-buildings into lp:widelands

2019-02-27 Thread hessenfarmer
@GunChleoc >From my side this is ready to merge. Travis is not green due to a transient >failure. But as I am not an expert for this code I'll leave the decision for merging to you -- https://code.launchpad.net/~widelands-dev/widelands/bug-1796364-blinking-buildings/+merge/359348 Your team Wide

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/pybb_cleanup into lp:widelands-website

2019-02-27 Thread kaputtnik
alpha is up :-) -- https://code.launchpad.net/~widelands-dev/widelands-website/pybb_cleanup/+merge/363742 Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands-website/pybb_cleanup into lp:widelands-website. __