Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1810062-territorial-calculations into lp:widelands

2019-02-26 Thread hessenfarmer
Thanks again for the great work everybody. However travis si complaining about a missing newline in autogenerated rst files. It might be the case we need to insert an empty line at this line https://bazaar.launchpad.net/~widelands-dev/widelands/trunk/view/head:/src/scripting/lua_map.cc#L6612 --

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1810062-territorial-calculations into lp:widelands

2019-02-26 Thread GunChleoc
Thanks, should be fixed ow. -- https://code.launchpad.net/~widelands-dev/widelands/bug-1810062-territorial-calculations/+merge/361366 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1810062-territorial-calculations. _

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1796364-blinking-buildings into lp:widelands

2019-02-26 Thread hessenfarmer
I will test a windows debug build tonight. @ Klaus could you test this another time as well? -- https://code.launchpad.net/~widelands-dev/widelands/bug-1796364-blinking-buildings/+merge/359348 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1796364-blinking

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1817664-overlooping-eva_fail into lp:widelands

2019-02-26 Thread Benedikt Straub
Benedikt Straub has proposed merging lp:~widelands-dev/widelands/bug-1817664-overlooping-eva_fail into lp:widelands. Commit message: Shorten a soldier's last evade_failure animation if the soldier is about to die to prevent overlooping. The health bar falls gradually during an attack instead of

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/territorial_unify_notifications into lp:widelands

2019-02-26 Thread bunnybot
Continuous integration builds have changed state: Travis build 4529. State: passed. Details: https://travis-ci.org/widelands/widelands/builds/498743350. Appveyor build 4316. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_territoria

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1796364-blinking-buildings into lp:widelands

2019-02-26 Thread hessenfarmer
Review: Approve playtest Tested with the latest win debug build from appveyor. no crashes and I couldn't see any blinking buildings or similar. -- https://code.launchpad.net/~widelands-dev/widelands/bug-1796364-blinking-buildings/+merge/359348 Your team Widelands Developers is subscribed to bran

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1817664-overlooping-eva_fail into lp:widelands

2019-02-26 Thread bunnybot
Continuous integration builds have changed state: Travis build 4530. State: failed. Details: https://travis-ci.org/widelands/widelands/builds/498892692. Appveyor build 4317. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_bug_181766

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1817664-overlooping-eva_fail into lp:widelands

2019-02-26 Thread GunChleoc
Review: Approve LGTM - thanks for the fix :) I have pushed some small code style tweaks - have a look at them if you want. @bunnybot merge -- https://code.launchpad.net/~widelands-dev/widelands/bug-1817664-overlooping-eva_fail/+merge/363679 Your team Widelands Developers is subscribed to branch