[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1798297-locale-C into lp:widelands

2018-11-06 Thread GunChleoc
GunChleoc has proposed merging lp:~widelands-dev/widelands/bug-1798297-locale-C into lp:widelands. Commit message: Fix fetching of translations when user locale is set to C. If the desired Widelands locale does not exist, try to fall back to en_US.utf8 to make libintl happy. Requested reviews:

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1800818 into lp:widelands

2018-11-06 Thread TiborB
TiborB has proposed merging lp:~widelands-dev/widelands/bug-1800818 into lp:widelands. Commit message: When IA finds that it has more than one barrack, it will disassemble abundant barracks. Should happen only after human player. Requested reviews: Widelands Developers (widelands-dev) Related

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/empire04_unused_key_return_on_dismantle_no_ui into lp:widelands

2018-11-06 Thread hessenfarmer
Ok I will try to find some time next week. -- https://code.launchpad.net/~widelands-dev/widelands/empire04_unused_key_return_on_dismantle_no_ui/+merge/358305 Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/empire04_unused_key_return_on_disma

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug_1801340_loading_screen into lp:widelands

2018-11-06 Thread Toni Förster
Toni Förster has proposed merging lp:~widelands-dev/widelands/bug_1801340_loading_screen into lp:widelands. Commit message: always set background for progresswindow to left bottom Requested reviews: Widelands Developers (widelands-dev) Related bugs: Bug #1801340 in widelands: "Picture in loa

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug_1801340_loading_screen into lp:widelands

2018-11-06 Thread Benedikt Straub
Scenarios can have a custom background image. Those are screen-filling and should be centered (that´s the reason for the different alignment in the if-else I think). Did you test what they look like now (e.g. campaign maps in bar and emp campaigns, photographs in fri campaign)? -- https://code.

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug_1801340_loading_screen into lp:widelands

2018-11-06 Thread Toni Förster
Will do this later. Didn't consider those, though. So I guess they'll look worse now... -- https://code.launchpad.net/~widelands-dev/widelands/bug_1801340_loading_screen/+merge/358378 Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/bug_180

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug_1801340_loading_screen into lp:widelands

2018-11-06 Thread Toni Förster
Barbarians look good in 1280x800 but that's the maximum resolution I can test. Any way to unlock all campaigns without playing them? -- https://code.launchpad.net/~widelands-dev/widelands/bug_1801340_loading_screen/+merge/358378 Your team Widelands Developers is requested to review the proposed m

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug_1801340_loading_screen into lp:widelands

2018-11-06 Thread Benedikt Straub
You can either edit your ~/.widelands/save/campvis file or start WL with the commandline option --scenario=campaigns/fri01.wmf You can also test higher resolutions using --xres=4000 --yres=3000 --fullscreen=false and then move the window around the screen to see it all. (The result when the reso

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug_1801340_loading_screen into lp:widelands

2018-11-06 Thread GunChleoc
I agree that the campaign scenario backgrounds should stay centered. -- https://code.launchpad.net/~widelands-dev/widelands/bug_1801340_loading_screen/+merge/358378 Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/bug_1801340_loading_screen i

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1800818 into lp:widelands

2018-11-06 Thread GunChleoc
Review: Approve Code LGTM, not tested yet -- https://code.launchpad.net/~widelands-dev/widelands/bug-1800818/+merge/358368 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1800818. ___ Mailing list: https://launch

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1800818 into lp:widelands

2018-11-06 Thread GunChleoc
The proposal to merge lp:~widelands-dev/widelands/bug-1800818 into lp:widelands has been updated. Commit message changed to: When An AI finds that it has more than one barracks, it will disassemble the additional barracks. Should happen only after taking over from a human player. For more deta

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1800182-focus-save-menu into lp:widelands

2018-11-06 Thread GunChleoc
Can you open up a new bug report for the problem with the passing on of keypresses? Let's target that one to Build 21, since it's an old issue. -- https://code.launchpad.net/~widelands-dev/widelands/bug-1800182-focus-save-menu/+merge/358284 Your team Widelands Developers is subscribed to branch

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug_1801340_loading_screen into lp:widelands

2018-11-06 Thread Toni Förster
The problem seems to be in gamehost.cc: UI::ProgressWindow* loader_ui = new UI::ProgressWindow("images/loadscreens/progress.png"); and gameclient.cc loader_ui.reset(new UI::ProgressWindow("images/loadscreens/progress.png")); Since they provide a file-name, only the if-clause is called. Have

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug_1801340_loading_screen into lp:widelands

2018-11-06 Thread Toni Förster
The proposal to merge lp:~widelands-dev/widelands/bug_1801340_loading_screen into lp:widelands has been updated. Commit message changed to: don't provide the filename for the standard background image For more details, see: https://code.launchpad.net/~widelands-dev/widelands/bug_1801340_loading

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug_1801340_loading_screen into lp:widelands

2018-11-06 Thread Toni Förster
Okay that did the trick. Only images that cam be centered should be passed as an argument. -- https://code.launchpad.net/~widelands-dev/widelands/bug_1801340_loading_screen/+merge/358378 Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/bug_1

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug_1801340_loading_screen into lp:widelands

2018-11-06 Thread GunChleoc
Review: Approve Looking good :) @bunnybot merge -- https://code.launchpad.net/~widelands-dev/widelands/bug_1801340_loading_screen/+merge/358378 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug_1801340_loading_screen. ___

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1800182-focus-save-menu into lp:widelands

2018-11-06 Thread Arty
Bug report is up. -- https://code.launchpad.net/~widelands-dev/widelands/bug-1800182-focus-save-menu/+merge/358284 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1800182-focus-save-menu. ___ Mailing list: https:/

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1800814-update-script into lp:widelands

2018-11-06 Thread GunChleoc
GunChleoc has proposed merging lp:~widelands-dev/widelands/bug-1800814-update-script into lp:widelands. Commit message: Copy the version file instead of moving it, so that the update script can be run twice in a row. Requested reviews: Widelands Developers (widelands-dev) Related bugs: Bug