Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/shipyard_statistics into lp:widelands

2018-09-07 Thread GunChleoc
Review: Approve LGTM :) Let's wait for the other branch to go in, then merge this. -- https://code.launchpad.net/~widelands-dev/widelands/shipyard_statistics/+merge/354208 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1786613-10s-return-skipped. ___

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1786613-10s-return-skipped into lp:widelands

2018-09-07 Thread GunChleoc
LGTM :) @bunnybot merge -- https://code.launchpad.net/~widelands-dev/widelands/bug-1786613-10s-return-skipped/+merge/354381 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1786613-10s-return-skipped. ___ Mailing

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1786613-10s-return-skipped into lp:widelands

2018-09-07 Thread GunChleoc
The proposal to merge lp:~widelands-dev/widelands/bug-1786613-10s-return-skipped into lp:widelands has been updated. Commit message changed to: Introduced the return value no_stats for work programs. For more details, see: https://code.launchpad.net/~widelands-dev/widelands/bug-1786613-10s-ret

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/big_inn_missing_animation into lp:widelands

2018-09-07 Thread Toni Förster
Toni Förster has proposed merging lp:~widelands-dev/widelands/big_inn_missing_animation into lp:widelands. Commit message: added missing working animation for barbarians big_inn Requested reviews: Widelands Developers (widelands-dev) For more details, see: https://code.launchpad.net/~wideland

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/animation_woodhardener into lp:widelands

2018-09-07 Thread Toni Förster
Toni Förster has proposed merging lp:~widelands-dev/widelands/animation_woodhardener into lp:widelands. Commit message: Use working animations for the barbarians wood hardener. They were in place but idle animation were used instead. Requested reviews: Widelands Developers (widelands-dev) F

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/animation_woodhardener into lp:widelands

2018-09-07 Thread hessenfarmer
Review: Approve LGTM Good spot -- https://code.launchpad.net/~widelands-dev/widelands/animation_woodhardener/+merge/354465 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/animation_woodhardener. ___ Mailing list: ht

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/big_inn_missing_animation into lp:widelands

2018-09-07 Thread hessenfarmer
Review: Approve Very good catch -- https://code.launchpad.net/~widelands-dev/widelands/big_inn_missing_animation/+merge/354466 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/big_inn_missing_animation. ___ Mailing l

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/empire04_bug_fix_enhance into lp:widelands

2018-09-07 Thread hessenfarmer
Review: Approve Currently it's not possible to have the farms dismanteable after the plans are found as the objective to click on the farm window works fine I Think we should have this. @bunnybot merge -- https://code.launchpad.net/~widelands-dev/widelands/empire04_bug_fix_enhance/+merge/35374

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/macos_build_app_ICU into lp:widelands

2018-09-07 Thread Toni Förster
Toni Förster has proposed merging lp:~widelands-dev/widelands/macos_build_app_ICU into lp:widelands. Commit message: check for minor version of CMake only export ICU_ROOT if CMake version is lower than 3.12 Requested reviews: Widelands Developers (widelands-dev) For more details, see: https

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/rework-resource-indicators into lp:widelands

2018-09-07 Thread Benedikt Straub
Uploaded new graphics for empire and atlantean resis. How about these? -- https://code.launchpad.net/~widelands-dev/widelands/rework-resource-indicators/+merge/353996 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/rework-resource-indicators. __

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/macos_build_app_ICU into lp:widelands

2018-09-07 Thread Klaus Halfmann
Review: Approve code review Code looks ok and will not afect normal builds in any way. Go for it. I cannot use this anyway as I use Macports. -- https://code.launchpad.net/~widelands-dev/widelands/macos_build_app_ICU/+merge/354490 Your team Widelands Developers is subscribed to branch lp:~widel