Review: Approve
As far as it concerns me, this looks ok ;-P
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1786597-test-suite/+merge/352928
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1786597-test-suite.
Thanks for the review! :)
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1786597-test-suite/+merge/352928
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1786597-test-suite.
___
Mailin
The proposal to merge lp:~widelands-dev/widelands/macos_build_app into
lp:widelands has been updated.
Commit message changed to:
The script for building on macOS uses gcc-7 now. Also it checks whether the
SDK10.7 is installed or not and uses the latest installed version if it cannot
find the o
Continuous integration builds have changed state:
Travis build 3779. State: errored. Details:
https://travis-ci.org/widelands/widelands/builds/415308135.
Appveyor build 3578. State: failed. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_bug_178616
Toni Förster has proposed merging
lp:~widelands-dev/widelands/bug-1786613-10s-return-skipped into lp:widelands.
Commit message:
Reduce waiting time to 10ms for skipped programs.
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #1786613 in widelands: "production times
Toni Förster has proposed merging
lp:~widelands-dev/widelands/bug-1786613-10s-return-skipped into lp:widelands.
Commit message:
reduce waiting time to 10ms for skipped programs
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #1786613 in widelands: "production times
Transient error on Travis
@bunnybot merge force
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1786597-test-suite/+merge/352928
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1786597-test-suite.
___
The proposal to merge lp:~widelands-dev/widelands/bug-1786597-test-suite into
lp:widelands has been updated.
Commit message changed to:
Fix the testsuite for carriers
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/bug-1786597-test-suite/+merge/352928
--
Your team Wi
Continuous integration builds have changed state:
Travis build 3780. State: errored. Details:
https://travis-ci.org/widelands/widelands/builds/415308939.
Appveyor build 3579. State: failed. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_bug_178659
Refusing to merge, since Travis is not green. Use @bunnybot merge force for
merging anyways.
Travis build 3780. State: errored. Details:
https://travis-ci.org/widelands/widelands/builds/415308939.
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1786597-test-suite/+merge/352928
Your t
@bunnybot merge force
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1786597-test-suite/+merge/352928
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1786597-test-suite.
___
Mailing list: https://launc
GunChleoc has proposed merging
lp:~widelands-dev/widelands/fix-frisian-trainingsites-food-help into
lp:widelands.
Commit message:
Fix food help for Frisian Training Camp.
Requested reviews:
Widelands Developers (widelands-dev)
For more details, see:
https://code.launchpad.net/~widelands-dev/
Originally reported on the forum: https://wl.widelands.org/forum/topic/4312/
--
https://code.launchpad.net/~widelands-dev/widelands/fix-frisian-trainingsites-food-help/+merge/352977
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/fix-frisian
Toni Förster has proposed merging
lp:~widelands-dev/widelands/missing_animations_barbarians_wood_hardener into
lp:~widelands-dev/widelands/mines-worldsavior.
Commit message:
Use working animations for the barbarians wood hardener.
They where in place but idle animation were used instead.
Reque
The proposal to merge lp:~widelands-dev/widelands/bug-1786597-test-suite into
lp:widelands has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/bug-1786597-test-suite/+merge/352928
--
Your team Widelands Developers is su
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1619402-port-work-area-on-expedition/+merge/349594
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1619402-port-work-area-on-expedition.
_
Yes, if scenarios actually use nonexistent buildings, saveloading will tell the
player so via UI if such a building has been built.
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/lenient_allowed_buildings/+merge/351749
Your team Widelands Developers is subscribed to branc
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1785404-chat-scrolling/+merge/352941
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1785404-chat-scrolling.
___
Mailing list: https://lau
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/macos_build_app/+merge/352945
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/macos_build_app.
___
Mailing list: https://launchpad.net/~widelands-
Toni Förster has proposed merging
lp:~widelands-dev/widelands/remove_executable_bit into lp:widelands.
Commit message:
remove executable bit from files that are not supposed to have it
Requested reviews:
Widelands Developers (widelands-dev)
For more details, see:
https://code.launchpad.net/~w
Continuous integration builds have changed state:
Travis build 3782. State: failed. Details:
https://travis-ci.org/widelands/widelands/builds/415390227.
Appveyor build 3581. State: success. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_bug_178661
Review: Approve
Good catch :)
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/remove_executable_bit/+merge/353012
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/remove_executable_bit.
___
Mai
Review: Approve
Thanks! Probably got lost when we did he big conversion from conf to Lua files
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/missing_animations_barbarians_wood_hardener/+merge/352980
Your team Widelands Developers is subscribed to branch
lp:~widelands-de
Review: Approve
LGTM!
Thanks for fixing.
--
https://code.launchpad.net/~widelands-dev/widelands/fix-frisian-trainingsites-food-help/+merge/352977
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/fix-frisian-trainingsites-food-help.
_
Review: Approve
yes
good catch
--
https://code.launchpad.net/~widelands-dev/widelands/missing_animations_barbarians_wood_hardener/+merge/352980
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/mines-worldsavior.
___
Review: Needs Fixing
Ok I tested this with different timings.
My machine is a Core 2 Duo T7500 @ 2,2 Ghz with 4 GB RAM.
My setup was
map: the nile
8 AI players 2 of each tribe
Let the game run for 4:50 hours
saved and loaded with every config.
results were:
original timing: around 30% cpu usage
The proposal to merge
lp:~widelands-dev/widelands/bug-1786613-10s-return-skipped into lp:widelands
has been updated.
Status: Needs review => Superseded
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/bug-1786613-10s-return-skipped/+merge/352967
--
Your team Widel
Toni Förster has proposed merging
lp:~widelands-dev/widelands/bug-1786613-500ms-return-skipped into lp:widelands.
Commit message:
reduce waiting time to 500ms for skipped programs
Requested reviews:
hessenfarmer (stephan-lutz)
Related bugs:
Bug #1786613 in widelands: "production times are 10
Continuous integration builds have changed state:
Travis build 3783. State: failed. Details:
https://travis-ci.org/widelands/widelands/builds/415471904.
Appveyor build 3582. State: success. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_fix_frisia
Toni Förster has proposed merging
lp:~widelands-dev/widelands/macos_build_app_compiler into lp:widelands with
lp:~widelands-dev/widelands/macos_build_app as a prerequisite.
Commit message:
choose between Clang and GCC
Requested reviews:
Widelands Developers (widelands-dev)
For more details,
The proposal to merge lp:~widelands-dev/widelands/macos_build_app_compiler into
lp:widelands has been updated.
Commit message changed to:
choose between compiler clang or gcc, specify build type: debug or release
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/macos_b
The proposal to merge lp:~widelands-dev/widelands/macos_build_app_compiler into
lp:widelands has been updated.
Description changed to:
One can choose between Clang and GCC now. The Wiki has been changed accordingly:
https://wl.widelands.org/wiki/Building Widelands on macOS/
For more details, s
The proposal to merge lp:~widelands-dev/widelands/macos_build_app_compiler into
lp:widelands has been updated.
Description changed to:
One can choose between Clang and GCC now. The Wiki has been changed accordingly:
https://wl.widelands.org/wiki/BuildingWidelandsonmacOS/
For more details, see:
The proposal to merge lp:~widelands-dev/widelands/macos_build_app_compiler into
lp:widelands has been updated.
Description changed to:
One can choose between Clang and GCC now. The Wiki has been changed accordingly:
https://wl.widelands.org/wiki/Building_Widelands_on_macOS/
For more details, s
Continuous integration builds have changed state:
Travis build 3785. State: passed. Details:
https://travis-ci.org/widelands/widelands/builds/415536722.
Appveyor build 3584. State: success. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_macos_buil
The proposal to merge lp:~widelands-dev/widelands/macos_build_app into
lp:widelands has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/macos_build_app/+merge/352945
--
Your team Widelands Developers is subscribed to br
Continuous integration builds have changed state:
Travis build 3786. State: passed. Details:
https://travis-ci.org/widelands/widelands/builds/415538286.
Appveyor build 3585. State: success. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_bug_178540
The proposal to merge lp:~widelands-dev/widelands/bug-1785404-chat-scrolling
into lp:widelands has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/bug-1785404-chat-scrolling/+merge/352941
--
Your team Widelands Develope
Review: Approve
Code LGTM :)
--
https://code.launchpad.net/~widelands-dev/widelands/macos_build_app_compiler/+merge/353035
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/macos_build_app.
___
Mailing list: https://la
Review: Approve
Looks good from my side now.
Would be good though if somebody with an underpowered machine would confirm
minimal effect on performance
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1786613-500ms-return-skipped/+merge/353028
Your team Widelands Developers is subscribe
40 matches
Mail list logo
