Thanks for the fix!
I thin the sleep should be before the play_sound too, so that the sound will go
with the animation?
You also accidentally committed some changes to the translation files.
--
https://code.launchpad.net/~stonerl/widelands/big_inn_missing_animation/+merge/352844
Your team Widel
I have fixed the disappearing work area when a construction site finishes, so
this can go in now. Thanks for the review and for tracking down the bug :)
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1619402-port-work-area-on-expedition/+merge/349594
Your team Widelan
The proposal to merge lp:~widelands-dev/widelands/ship_scheduling_2 into
lp:widelands has been updated.
Commit message changed to:
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/ship_scheduling_2/+merge/352335
--
Your team Widelands Developers is requested to revie
The proposal to merge lp:~widelands-dev/widelands/ship_scheduling_2 into
lp:widelands has been updated.
Description changed to:
See description of the branch:
https://code.launchpad.net/~widelands-dev/widelands/ship_scheduling_2
Get windows builds and ask for testing - do not review yet
For mo
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1784113-desktop-file-utils/+merge/351614
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/bug-1784113-desktop-file-utils into lp:widelands.
__
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1784490-show-version-in-mac-finder/+merge/352874
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/bug-1784490-show-version-in-mac-finder into
lp:widelands.
_
GunChleoc has proposed merging
lp:~widelands-dev/widelands/bug-1784490-show-version-in-mac-finder into
lp:widelands.
Commit message:
Add CFBundleShortVersionString to Mac builds.
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #1784490 in widelands: "macOS: Version
The proposal to merge
lp:~widelands-dev/widelands/bug-1784113-desktop-file-utils into lp:widelands
has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/bug-1784113-desktop-file-utils/+merge/351614
--
Your team Widelands
Review: Disapprove
The underlying bug should be fixed. Thanks for spotting it. However as the
merge request is not tegeted to trunk but to the Mines-worldsavior branch it
should have been branched from this branch. instead it is branche from trunk
which leads to difficulties. So I would propose
Continuous integration builds have changed state:
Travis build 3764. State: errored. Details:
https://travis-ci.org/widelands/widelands/builds/414390985.
Appveyor build 3563. State: success. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_mines_wor
Toni Förster has proposed merging
lp:~stonerl/widelands/big_inn_missing_animation_fixed into
lp:~widelands-dev/widelands/mines-worldsavior.
Requested reviews:
hessenfarmer (stephan-lutz)
For more details, see:
https://code.launchpad.net/~stonerl/widelands/big_inn_missing_animation_fixed/+merg
The proposal to merge lp:~stonerl/widelands/big_inn_missing_animation into
lp:~widelands-dev/widelands/mines-worldsavior has been updated.
Status: Needs review => Superseded
For more details, see:
https://code.launchpad.net/~stonerl/widelands/big_inn_missing_animation/+merge/352844
--
Your
My suggestion has been based solely on general programming principles, not on
reading the code. I'm not familiar with the relevant files. I had a look and
they are a mess (as most of the codebase is). If someone points me to specific
places in the code, maybe I could do it.
--
https://code.laun
leading sleep times (penalty for not being supplied with all wares) have been
reduced intentionally. However they are still different between the food
preparing buildings of the tribes ( taverns, inns, big inns, drinking halls,
etc.)
Therefore I would propose to have an equal leading sleep tim
Continuous integration builds have changed state:
Travis build 3765. State: errored. Details:
https://travis-ci.org/widelands/widelands/builds/414409747.
Appveyor build 3564. State: success. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_bug_17844
Refusing to merge, since Travis is not green. Use @bunnybot merge force for
merging anyways.
Travis build 3765. State: errored. Details:
https://travis-ci.org/widelands/widelands/builds/414409747.
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1784490-show-version-in-mac-finder/+mer
Hope this is what you imagined.
--
https://code.launchpad.net/~stonerl/widelands/big_inn_missing_animation_fixed/+merge/352887
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/mines-worldsavior.
___
Mailing list: https
Continuous integration builds have changed state:
Travis build 3766. State: errored. Details:
https://travis-ci.org/widelands/widelands/builds/414411279.
Appveyor build 3565. State: success. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_lenient_a
Refusing to merge, since Travis is not green. Use @bunnybot merge force for
merging anyways.
Travis build 3767. State: errored. Details:
https://travis-ci.org/widelands/widelands/builds/414413078.
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1619402-port-work-area-on-expedition/+m
Continuous integration builds have changed state:
Travis build 3767. State: errored. Details:
https://travis-ci.org/widelands/widelands/builds/414413078.
Appveyor build 3566. State: success. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_bug_16194
Review: Approve
exactly. Thanks a lot. Just a quick question:
Ican't do any changes until Monday as I am not at home, could you do the same
for empire and frisians buildings as well?
If yes we should wait with the merge. If no this can go in.
--
https://code.launchpad.net/~stonerl/widelands/b
Yes, no problem. But I found a severe problem regarding production times:
https://wl.widelands.org/forum/post/25597/
This also affects the inns.
> On 10. Aug 2018, at 22:36, hessenfarmer wrote:
>
> Review: Approve
>
> exactly. Thanks a lot. Just a quick question:
>
> Ican't do any changes un
> exactly. Thanks a lot. Just a quick question:
>
> Ican't do any changes until Monday as I am not at home, could you do the same
> for empire and frisians buildings as well?
> If yes we should wait with the merge. If no this can go in.
Done.
--
https://code.launchpad.net/~stonerl/widelands/big_
23 matches
Mail list logo
