Review: Approve
I don't understand your TODO comment. Not all of them are available in the
Options screen, but they should all do something. Also, ai_training is
documented, so which ones do you mean?
I remember we had a bug somewhere about guaranteeing completeness, but I can't
find it.
LGTM
> I would have to write a lot of Zeros to the file
Why do you think that? If you want 1 value, write 1 value.
> For example you could take the decisions contained in empire 4 (How to deal
> with the monastry) or fri02 (peace Option or war Option) you could easily use
> these decisions in follow
Sounds good to me. I can't think of any other states right now, so I'd say the
design is finished :)
--
https://code.launchpad.net/~widelands-dev/widelands/net-online-game-status/+merge/343768
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/net-remove-tell_ip.
The proposal to merge lp:~widelands-dev/widelands/frisians-fix into
lp:widelands has been updated.
Commit message changed to:
Three small changes to the frisians tribe:
- Corrected requires_supporters AI hint in aqua farm, beekeeper, fruit collector
- Corrected drinking hall helptext
- New junip
Ok now I understand the thing better.
Of course Organising the file in different tables containing variables by their
type, would make sense.
However as I can't imagine yet what things could be useful to save in the
future, the Format should be able to cope with this. So it should provide some
f
Review: Approve
Diff and testing look good. Only visual change I noticed is the new clock in
games in release builds.
I would prefer having a configuration option for the clock, but doesn't have to
be in this branch or at all.
Diff comments:
> === modified file 'src/wui/interactive_base.cc'
>
Review: Approve
Testing worked fine, one comment in the diff.
As a suggestion: What about moving spectators to the first player position on
new games, too?
Diff comments:
>
> === modified file 'src/wui/interactive_gamebase.cc'
> --- src/wui/interactive_gamebase.cc 2018-04-07 16:59:00 +
Review: Approve
Only looked at the code, do you also want some testing?
Code looks good so far, two comments are in the diff.
Diff comments:
>
> === modified file 'src/wui/shipwindow.cc'
> --- src/wui/shipwindow.cc 2018-04-07 16:59:00 +
> +++ src/wui/shipwindow.cc 2018-04-17 03:10:4
TiborB has proposed merging lp:~widelands-dev/widelands/road_promotions into
lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/road_promotions/+merge/344182
This is only formal request to get window
Continuous integration builds have changed state:
Travis build 3410. State: failed. Details:
https://travis-ci.org/widelands/widelands/builds/370745495.
Appveyor build 3216. State: success. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_road_promo
10 matches
Mail list logo
