Thanks for pointing that out - there are multiple things in that script that
won't work with Python 3 and a fix isn't trivial, so I've changed the Python
header.
--
https://code.launchpad.net/~widelands-dev/widelands/translation_stats/+merge/332029
Your team Widelands Developers is subscribed to
http://www.cplusplus.com/reference/deque/deque/:
> For operations that involve frequent insertion or removals of elements at
> positions other than the beginning or the end, deques perform worse and have
> less consistent iterators and references than lists and forward lists.
dequeue over vecto
I did some testing now. I don't get a crash in trunk, but the builder would
disappear, while this branch will keep the extra builder on the Ship and return
him to a port. So, definitely an improvement! I'll assume that the crash is
fixed too and close the bug.
@bunnybot merge
--
https://code.l
kaputtnik has proposed merging
lp:~widelands-dev/widelands-website/media_cleanup into lp:widelands-website.
Requested reviews:
Widelands Developers (widelands-dev)
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands-website/media_cleanup/+merge/333088
Some cleanup in th
I have added comments to the things that I plan not to change - will need to go
through the rest in detail.
Diff comments:
> === modified file 'data/tribes/init.lua'
> --- data/tribes/init.lua 2017-02-12 09:10:57 +
> +++ data/tribes/init.lua 2017-09-03 11:19:20 +
> @@ -11,12 +1
Review: Needs Fixing
The regex doesn't match here and the match is always 'None', resulting in the
List out of range error.
Don't know how to fix the regex... but maybe adding an else clause? See diff
comment.
Diff comments:
>
> === added file 'utils/update_translation_stats.py'
> --- utils/
The proposal to merge lp:~widelands-dev/widelands/bug-1727673 into lp:widelands
has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/bug-1727673/+merge/332945
--
Your team Widelands Developers is requested to review the
It fails for me with Python3 too, but not with Python2. Good idea about the
error handling though. I've added some :)
--
https://code.launchpad.net/~widelands-dev/widelands/translation_stats/+merge/332029
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/translat
I have removed the playercommand now.
Here's what I remember of the vision code:
Vision state of a field is an integer. Everything in sight of a building with
vision is always visible. Every time a worker walks past an area, the vision on
the field is incremented. It then slowly gets decremente
Diff comments:
> === modified file 'data/tribes/init.lua'
> --- data/tribes/init.lua 2017-02-12 09:10:57 +
> +++ data/tribes/init.lua 2017-09-03 11:19:20 +
> @@ -11,12 +11,33 @@
> --
> -- Basic load order (first wares, then immovables etc.) is important,
> -- because checks
Just want to mention that i did run the file with python2 :-) This is what i
get now:
$:> python2 utils/update_translation_stats.py
Fetching translation stats .
ERROR: Invalid line in pocount output:
/home/kaputtnik/Quellcode/widelands-repo/translation_stats/po/map_the_green_plateau.wmf/la.po
s
TiborB has proposed merging lp:~widelands-dev/widelands/bug-1728006 into
lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #1728006 in widelands: "AI crashes when a producer is also supporter"
https://bugs.launchpad.net/widelands/+bug/1728006
For more
The problem with list is that everytime item is added/removed the memory is
allocated/deallocated. The deques and vectors behave differently. And this is
the main goal - reduce number of memory de/allocations.
Also I saw some benchmarks and std::list were quite slow - depending on what
you are d
BTW, can you tell where the first builder came from?
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1727673/+merge/332945
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/bug-1727673 into lp:widelands.
___
Continuous integration builds have changed state:
Travis build 2729. State: passed. Details:
https://travis-ci.org/widelands/widelands/builds/295908441.
Appveyor build 2541. State: failed. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_translation
Continuous integration builds have changed state:
Travis build 2730. State: passed. Details:
https://travis-ci.org/widelands/widelands/builds/295909572.
Appveyor build 2542. State: failed. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_reveal_hide
16 matches
Mail list logo
