Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/reveal_hide_animations into lp:widelands

2017-07-12 Thread GunChleoc
Review: Approve I have done some testing now, so this is ready to go in as soon as somebody does a code review on the prerequisite branch. -- https://code.launchpad.net/~widelands-dev/widelands/reveal_hide_animations/+merge/327062 Your team Widelands Developers is subscribed to branch lp:~widel

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/reveal_hide_animations into lp:widelands

2017-07-12 Thread hessenfarmer
I'm not happy with the code changes in empire 03 mission. 1. I wanted intentionally to reveal more land around the ruin of the fortress as already seen by the player, like if theres has been send a scout or an intelligence agent. 2. the line to hide the region around the starting filed is absol

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/reveal_hide_animations into lp:widelands

2017-07-12 Thread kaputtnik
> 1. I wanted intentionally to reveal more land around the ruin of the > fortress as already seen by the player, When playtesting i found that revealing randomly has not really an effect because most of the fields are already seen by the player. Additionally calling reveal_randomly() do now hid