Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/00_private_inheritance into lp:widelands

Diff comments: > > === modified file 'src/logic/cmd_luacoroutine.cc' > --- src/logic/cmd_luacoroutine.cc 2017-01-25 18:55:59 + > +++ src/logic/cmd_luacoroutine.cc 2017-07-05 21:50:35 + > @@ -51,11 +53,11 @@ > log("%s\n", e.what()); > log("Send message

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/reveal_hide_animations into lp:widelands

A couple of nits, code LGTM otherwise. Needs testing. Diff comments: > > === modified file 'data/campaigns/bar01.wmf/scripting/mission_thread.lua' > --- data/campaigns/bar01.wmf/scripting/mission_thread.lua 2016-12-29 > 10:31:07 + > +++ data/campaigns/bar01.wmf/scripting/mission_thread.

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/reveal_hide_animations into lp:widelands

Many thanks for the review :-) Regarding the use of 'local' i added local to the other variables too and tested this. Of course i have tested all the changes, but having an additional test is better. -- https://code.launchpad.net/~widelands-dev/widelands/reveal_hide_animations/+merge/327062 Yo