Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/00_private_inheritance into lp:widelands

2017-07-05 Thread SirVer
This was the cleanup I originally intended to do when I ran into doc issues and failing tests in the lint suite. These are all refactorings to make the code smell better. -- https://code.launchpad.net/~widelands-dev/widelands/00_private_inheritance/+merge/326886 Your team Widelands Developers is

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/00_private_inheritance into lp:widelands

2017-07-05 Thread SirVer
SirVer has proposed merging lp:~widelands-dev/widelands/00_private_inheritance into lp:widelands. Commit message: - Replace private inheritance with composition everywhere. - Add a lint to forbid private inheritance. - Use std::unique_ptr<> in more places to signify passing or having ownership. -

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/00_private_inheritance into lp:widelands

2017-07-05 Thread bunnybot
Continuous integration builds have changed state: Travis build 2432. State: failed. Details: https://travis-ci.org/widelands/widelands/builds/250492535. Appveyor build 2259. State: failed. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_00_private_

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/00_private_inheritance into lp:widelands

2017-07-05 Thread bunnybot
Continuous integration builds have changed state: Travis build 2433. State: passed. Details: https://travis-ci.org/widelands/widelands/builds/250558716. Appveyor build 2260. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_00_private