Yay, all clean! :D
Yep, the remaining warnings in clang and GCC are unrelated to this one and need
separate fixes.
--
https://code.launchpad.net/~widelands-dev/widelands/compiler_warnings_062017_windows/+merge/326232
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widel
cppcheck would be nice, but only without failing the builds - the 3 memory
leaks cited above are false positives. We'd have to completely redesign the
memory handling in the Panel class to get rid of those warnings. Since it has
proven to work fine across many years, I am very reluctant to inves
2 nits:
In cmake/codecheck/rules/camel_case_for_classes:
"Use CapitalLetterWithCamelCase when naming an enum class, struct, or
\"using\".")
-> "Use CapitalLetterWithCamelCase when naming an enum class, class, struct,
or \"using\".")
src/build_info.h
/// \return the build id which is a
@Notabilis: thanks!
@klaus: Thanks for documenting your experience with Win10, even if it didn't
work. It would be nice if we could start the ending without sound or graphics,
but it's not possible yet.
--
https://code.launchpad.net/~widelands-dev/widelands/net-internetgaming-ipv6/+merge/326027
Yes, let's merge this :)
@bunnybot merge
BTW: I have all my editors set to automatically kill trailing whitespaces. This
helps keeping the diffs small and avoids that particular codecheck fail.
--
https://code.launchpad.net/~widelands-dev/widelands/ai-post-b19-2/+merge/325796
Your team Wideland
Oh, I did not know such feature exists. My editor (geany) has it so I will
enable it...
--
https://code.launchpad.net/~widelands-dev/widelands/ai-post-b19-2/+merge/325796
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/ai_trainingsites_proportion.
The proposal to merge lp:~widelands-dev/widelands/ai-post-b19-2 into
lp:widelands has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/ai-post-b19-2/+merge/325796
--
Your team Widelands Developers is subscribed to branch
kaputtnik has proposed merging
lp:~widelands-dev/widelands-website/mathjax_for_documentation into
lp:widelands-website.
Requested reviews:
Widelands Developers (widelands-dev)
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands-website/mathjax_for_documentation/+merge/3
> I've made a website-branch to fix displaying of formulas when switching to
> mathjax:
> https://code.launchpad.net/~widelands-dev/widelands-website/mathjax_for_documentation
Thanks! I think mathjax is a better solution for typesetting formulas (I
switched my personal blog also from images to m
Review: Approve
Thanks! There is no harm in merging this right-away, it is not user visible
unless mathjax is actually used.
--
https://code.launchpad.net/~widelands-dev/widelands-website/mathjax_for_documentation/+merge/326800
Your team Widelands Developers is subscribed to branch lp:widelands-
Review: Needs Fixing
Diff comments:
>
> === modified file 'src/base/md5.h'
> --- src/base/md5.h2017-01-25 18:55:59 +
> +++ src/base/md5.h2017-06-28 08:25:35 +
> @@ -74,7 +74,7 @@
> */
> template class MD5Checksum : public Base {
> public:
> - MD5Checksum() {
> + MD
Review: Approve
You're right, I overlooked that the comment continues in the following line.
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/codecheck/+merge/326647
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/codecheck.
The proposal to merge
lp:~widelands-dev/widelands-website/mathjax_for_documentation into
lp:widelands-website has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands-website/mathjax_for_documentation/+merge/326800
--
Your
The proposal to merge
lp:~widelands-dev/widelands-website/update_third_party_2017 into
lp:widelands-website has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands-website/update_third_party_2017/+merge/326188
--
Your team
Yes, you're right :-)
merged and deployed
--
https://code.launchpad.net/~widelands-dev/widelands-website/mathjax_for_documentation/+merge/326800
Your team Widelands Developers is subscribed to branch lp:widelands-website.
___
Mailing list: https://laun
merged and deployed
--
https://code.launchpad.net/~widelands-dev/widelands-website/update_third_party_2017/+merge/326188
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands-website/update_third_party_2017 into
lp:widelands-website.
___
Continuous integration builds have changed state:
Travis build 2391. State: passed. Details:
https://travis-ci.org/widelands/widelands/builds/247860909.
Appveyor build 2219. State: success. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_bug_986611
The proposal to merge lp:~widelands-dev/widelands/codecheck into lp:widelands
has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/codecheck/+merge/326647
--
Your team Widelands Developers is subscribed to branch
lp:~wi
18 matches
Mail list logo
