Continuous integration builds have changed state:
Travis build 2164. State: passed. Details:
https://travis-ci.org/widelands/widelands/builds/230634393.
Appveyor build 1999. State: success. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_refac_netc
Added some ideas for small improvements in the comments.
Diff comments:
>
> === renamed file 'src/network/nethost.h' => 'src/network/gamehost.h'
> --- src/network/nethost.h 2017-02-10 14:12:36 +
> +++ src/network/gamehost.h2017-05-10 05:43:49 +
> @@ -125,7 +125,7 @@
>
> v
Thanks for the review! I included nearly all of them in the commit, except for
you "Game or Net"-comment which was already correct.
--
https://code.launchpad.net/~widelands-dev/widelands/refac-netcode/+merge/323798
Your team Widelands Developers is requested to review the proposed merge of
lp:~w
Yes, I wasn't sure about that one.
Will download and do a bit of testing.
--
https://code.launchpad.net/~widelands-dev/widelands/refac-netcode/+merge/323798
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/refac-netcode into lp:widelands.
_
Review: Approve
Reviewed the code. lgtm, I left a few nits in the code in the last commit. Grep
for NOCOM please.
--
https://code.launchpad.net/~widelands-dev/widelands/refac-netcode/+merge/323798
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/refac-netcode.
5 matches
Mail list logo
