The attached savegames have both already be saved with this branch, so the code
of this branch does not react. Just my guess: You opened the single-player
b19-save with trunk, noticed missing barracks, saved and opened the bug report.
Then you opened and saved both games with this branch. Am I g
I attached another branch to the bug report, which should always enable
barracks on loading a game. For the record: I am against merging the other
branch since it breaks scenario savegames.
https://code.launchpad.net/~widelands-dev/widelands/bug-1685331-always-enable
--
https://code.launchpad.n
Review: Needs Fixing
I changed the width calculation to be based on the actual font size and text
content, but I still get an overlap/text cropping in the long game that I
attached to the bug. It's fine in English, but not fine in German or Gaelic.
You can emulate the effect by replacing labels
Compiling with clang should be fixed now - Travis is green.
--
https://code.launchpad.net/~widelands-dev/widelands/fh1_width_and_mapobject_messages/+merge/318189
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/fh1_width_and_mapobject_messages.
_
Somehow that savegame seems familiar...
The problem is that the slider does not use the new function at all but has up
to 7 hardcoded entries (see array time_in_ms). How many are shown is simply
determined based on which one are less than the elapsed gametime.
A simple fix would be to reduce the
kaputtnik has proposed merging
lp:~widelands-dev/widelands-website/notifications_cleanup into
lp:widelands-website.
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #1637632 in Widelands Website: "Cleanup notification_notice"
https://bugs.launchpad.net/widelands-we
OK, compiles now.
I will test/play this ... later
--
https://code.launchpad.net/~widelands-dev/widelands/fh1_width_and_mapobject_messages/+merge/318189
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/fh1_width_and_mapobject_messages.
__
Review: Resubmit
Fixed overlap of slider labels by measuring their drawing width. This means
that different languages will see different amounts of labels. Also sliders for
the ware statistics and the general statistics differ since the windows have
different widths. English and German seem to
Will review and test this this week. Thanks for continuing to bring the
complexity of the homepage down!
--
https://code.launchpad.net/~widelands-dev/widelands-website/notifications_cleanup/+merge/323457
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-d
Review: Approve
LGTM now - I just tweaked a comment a bit :)
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1655168-statistics-overlap/+merge/323441
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1655168-statistics-overlap.
__
10 matches
Mail list logo
