There is a segfault in the economy test on AppVeyor that Tino is still trying
to fix - nothing to do with this branch.
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/ship_path_dbg/+merge/318316
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/wide
The proposal to merge lp:~widelands-dev/widelands/ship_path_dbg into
lp:widelands has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/ship_path_dbg/+merge/318316
--
Your team Widelands Developers is subscribed to branch
The proposal to merge lp:~widelands-dev/widelands/bug-1653460-panel-init-width
into lp:widelands has been updated.
Commit Message changed to:
Fixed assertion failure in int UI::Panel::get_inner_h():
- Fixed bug with automatic column sizing for tables where the columns were
already being resize
GunChleoc has proposed merging
lp:~widelands-dev/widelands/bug-1653460-panel-init-width into lp:widelands.
Commit message:
Fixed assertion failure in int UI::Panel::get_inner_h():
- Fixed bug with automatic column sizing for tables where the columns were
already being resized before all of them
Tino has proposed merging lp:~widelands-dev/widelands/gcc63 into lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #1668200 in widelands: "Segfault on exit with GCC 6.3.0 Release Builds"
https://bugs.launchpad.net/widelands/+bug/1668200
For more details
The first change has
CMAKE_CXX_COMPILER_VERSION VERSION_EQUAL 6.3
and the second change has
CMAKE_CXX_COMPILER_VERSION VERSION_EQUAL 6.3.0
I guess one of them must be fixed?
I'd also rather have some research whether this breaks on non-Windows systems
as well and fix the segfault.
--
Thanks for the review!
The coordinates from std::map wanted_building_windows_ are used - I have marked
up the line.
I also fixed the window warping for both construction sites and dismantle sites
in all cases - having the window stay open is only 2 lines of code, so we might
as well do it in t
The proposal to merge lp:~widelands-dev/widelands/notifications_buildingwindows
into lp:widelands has been updated.
Commit Message changed to:
Building windows are now handled by a new notification 'NoteBuilding', so that
Map Objects and the economy no longer depend directly on wui. This also b
Going to fetch this now, but will need som testing on my multi Monitor setup.
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1653460-panel-init-width/+merge/318358
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/bug-1653460-panel
Review: Needs Fixing
Now Can always reproduce this :-(
Open in fullscreeen mode:
GRAPHICS REPORT
VIDEO DRIVER cocoa
pixel fmt 372645892
size 1440 900
END GRAPHICS REPORT
Open options menu:
4 widelands 0x000100946b2e
UI::Panel::set_size(int
Review: Resubmit
Next try - should be all fixed now.
> Minor nit (can be ignored): When the building is finished, the (minimized)
> window is brought to the front (!= maximized). Not really a problem in my
> opinion.
We will probably have to dig into the UI toolkit for that, so let's leave it
Review: Needs Fixing
konsole output and Backtrace:
widelands:
/home/kaputtnik/Quellcode/widelands-repo/bug-1653460-panel-init-width/src/ui_basic/panel.cc:243:
void UI::Panel::set_size(int, int): Assertion `nw >= 0' failed.
Thread 1 "widelands" received signal SIGABRT, Aborted.
0x7513b0
Continuous integration builds have changed state:
Travis build 2007. State: failed. Details:
https://travis-ci.org/widelands/widelands/builds/205821093.
Appveyor build 1843. State: failed. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_bug_1653460
Review: Approve
Thanks for fixing, diffs looks good to me and it works as wanted when testing.
Thanks for the change regarding upgrades and dismantling.
I don't really understand your fix for the segfault. As far as I can see, your
only change is storing the parent pointer now in the BuildingWi
Continuous integration builds have changed state:
Travis build 2008. State: passed. Details:
https://travis-ci.org/widelands/widelands/builds/205845483.
Appveyor build 1844. State: success. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_gcc63-1844
Continuous integration builds have changed state:
Travis build 2010. State: passed. Details:
https://travis-ci.org/widelands/widelands/builds/205917921.
Appveyor build 1846. State: failed. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_bug_1653254
Continuous integration builds have changed state:
Travis build 2011. State: passed. Details:
https://travis-ci.org/widelands/widelands/builds/205918080.
Appveyor build 1847. State: failed. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_notificatio
17 matches
Mail list logo
