GunChleoc has proposed merging
lp:~widelands-dev/widelands/notifications_economy_window into lp:widelands.
Commit message:
Economy windows are now handled by a new notification 'NoteEconomyWindow', so
that economy no longer knows about on ui_basic.
Requested reviews:
Widelands Developers (wid
* Source Package: widelands
* Version: 1:18-ppa0-bzr8186-201611230847~ubuntu14.04.1
* Architecture: i386
* Archive: ~widelands-dev/ubuntu/widelands-daily
* Component: main
* State: Failed to build
* Duration: 13 minutes
* Build Log:
https://launchpad.net/~widelands-dev/+archive/ubuntu/wid
* Source Package: widelands
* Version: 1:18-ppa0-bzr8186-201611230847~ubuntu14.04.1
* Architecture: amd64
* Archive: ~widelands-dev/ubuntu/widelands-daily
* Component: main
* State: Failed to build
* Duration: 14 minutes
* Build Log:
https://launchpad.net/~widelands-dev/+archive/ubuntu/wi
I like to add that the entire move was your suggestion! I don't have precise
conceptions for it.
What does the compiler say? So I can address all references in defaultai.h or
only the public ones?
--
https://code.launchpad.net/~widelands-dev/widelands/ai_seafaring_split/+merge/311544
Your team
It seems convenient to me that you (toptopple) make all changes in separate
file and not interfere with other logic of AI.
Compiler is happy and game with expedition works.
Main struct here is DefaultAI and both files defaulai.cc and
defaultai_seafaring.cc are defining functions inside the stru
Review: Approve
Checked the code and don't find objections. --> Approve
One thing you might consider still is to group declarations in defaultai.h as
to current AI segmentation, here: seafaring code.
Another thing you could think about is to, in the longer run, promote
segmentation of AI code
Replacing calls to WaresQueue with calls to the new InputQueue is done in
another branch:
https://code.launchpad.net/~widelands-dev/widelands/refactoring-input-queue
It can be merged either in this branch or into trunk after this branch is
merged.
Adding a workersQueue for the builder on expedit
Oh, forgot a comment: Priorities for WorkerQueues are and will stay disabled. I
am not completely sure what priorities are doing, but they only seem to
influence how likely it is that a carrier picks up a ware on a flag. Obviously,
this does not make sense for workers.
--
https://code.launchpad
Notabilis has proposed merging lp:~widelands-dev/widelands/bug-free-workers
into lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #1643209 in widelands: "No-cost workers are not removed correctly"
https://bugs.launchpad.net/widelands/+bug/1643209
For
I reordered declarations in defaultai.h a bit, perhaps it is better now.
I would like to have also opinion of SirVer or Gunchleoc on this kind of
change...
--
https://code.launchpad.net/~widelands-dev/widelands/ai_seafaring_split/+merge/311544
Your team Widelands Developers is subscribed to bran
Continuous integration builds have changed state:
Travis build 1645. State: failed. Details:
https://travis-ci.org/widelands/widelands/builds/178415914.
Appveyor build 1483. State: success. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_casern_wor
My opinion: great change! Thanks for refactoring.
At work we have a loose rule that no function should be longer than 50 lines
and no file longer than 1000 lines. This forces to think in modules, to reduce
coupling between components and to implement in small pieces that are easy to
understand
Review: Approve
good change, good catch. let's wait for travis before merging.
--
https://code.launchpad.net/~widelands-dev/widelands/bug-free-workers/+merge/311661
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-free-workers.
_
Review: Needs Fixing
I strongly approve of these moves towards making the logic UI agnostic!!!
I have a few suggestions to further separate UI and logic inline.
Diff comments:
>
> === modified file 'src/economy/economy.cc'
> --- src/economy/economy.cc2016-09-27 06:30:47 +
> +++ src/eco
14 matches
Mail list logo
