Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/casern_workersqueue into lp:widelands

2016-11-12 Thread Notabilis
GunChleoc, can you take a look at you "versioning" changes in map_buildingdata_packet.cc, please? The current version does not pass the regression tests. The problem is the line: if (packet_version > 5) { Since kCurrentPacketVersionProductionsite is still set to 5, the code differs on read

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/casern_workersqueue into lp:widelands

2016-11-12 Thread GunChleoc
Oops - definitely needs increasing to 6. -- https://code.launchpad.net/~widelands-dev/widelands/casern_workersqueue/+merge/309763 Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/casern_workersqueue into lp:widelands. ___

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/casern_workersqueue into lp:widelands

2016-11-12 Thread bunnybot
Continuous integration builds have changed state: Travis build 1597. State: errored. Details: https://travis-ci.org/widelands/widelands/builds/175308095. Appveyor build 1435. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_casern_wo

Re: [Widelands-dev] [Merge] lp:~7010622-q/widelands/topple-seafaring-1 into lp:widelands

2016-11-12 Thread TiborB
I see you had posted new map (nice one) and I hope you tested this branch on this map and found it better than current implementation in trunk... I see two border scenarios 1. Multiple islands with one port on each of them 2. One land = one sea - with multiple ports on them (here I am not sure