[Widelands-dev] [Merge] lp:~widelands-dev/widelands/prevent_ai_deadlocks into lp:widelands/build19

2016-11-01 Thread GunChleoc
GunChleoc has proposed merging lp:~widelands-dev/widelands/prevent_ai_deadlocks into lp:widelands/build19. Commit message: Added function to starting conditions to make sure that the AI never runs out of basic building materials in order to prevent deadlocks. Requested reviews: Widelands Deve

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/prevent_ai_deadlocks into lp:widelands/build19

2016-11-01 Thread TiborB
I strongly disagree. This is a step to slippery slope - once you get there we might never stop adding some cheatings to help AI. Moreover we already have cheating mode - Trading post. As I understand all that is needed is to add more logs for atlanteans when starting in village mode. Somehow th

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/fs-tile-background into lp:widelands

2016-11-01 Thread GunChleoc
@bunnybot merge -- https://code.launchpad.net/~widelands-dev/widelands/fs-tile-background/+merge/309673 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/fs-tile-background. ___ Mailing list: https://launchpad.net/~wide

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/fs-tile-background into lp:widelands

2016-11-01 Thread noreply
The proposal to merge lp:~widelands-dev/widelands/fs-tile-background into lp:widelands has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~widelands-dev/widelands/fs-tile-background/+merge/309673 -- Your team Widelands Developers is subscribed

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/prevent_ai_deadlocks into lp:widelands/build19

2016-11-01 Thread GunChleoc
I am in favor of merging this into B19 but NOT into trunk. Would that be OK for you? -- https://code.launchpad.net/~widelands-dev/widelands/prevent_ai_deadlocks/+merge/309727 Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/prevent_ai_deadlo

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/prevent_ai_deadlocks into lp:widelands/build19

2016-11-01 Thread bunnybot
Continuous integration builds have changed state: Travis build 1549. State: passed. Details: https://travis-ci.org/widelands/widelands/builds/172218875. Appveyor build 1390. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_prevent_ai

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/prevent_ai_deadlocks into lp:widelands/build19

2016-11-01 Thread kaputtnik
I think Tibor is right. Even if there are posts in the forum we have no bugreprot for this issue. And from my point of view bug reports are the things to go. The mentioned failure isn't such a show stopper as some users meant it is and it's quite worth for working on if there is no bug report.

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/prevent_ai_deadlocks into lp:widelands/build19

2016-11-01 Thread Tino
Review: Disapprove I also strongly oppose merging this to b19. I've added a bug report here: https://bugs.launchpad.net/widelands/+bug/1638260 Adding some more logs to the warehouse for fortified villages would be my way to go. -- https://code.launchpad.net/~widelands-dev/widelands/prevent_ai_

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/prevent_ai_deadlocks into lp:widelands/build19

2016-11-01 Thread GunChleoc
+1 for adding logs. How many do you think we need? -- https://code.launchpad.net/~widelands-dev/widelands/prevent_ai_deadlocks/+merge/309727 Your team Widelands Developers is subscribed to branch lp:widelands/build19. ___ Mailing list: https://launchpad

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/innosetup_appid into lp:widelands

2016-11-01 Thread Tino
Tino has proposed merging lp:~widelands-dev/widelands/innosetup_appid into lp:widelands. Requested reviews: Widelands Developers (widelands-dev) For more details, see: https://code.launchpad.net/~widelands-dev/widelands/innosetup_appid/+merge/309749 This should allow installing different deve

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/prevent_ai_deadlocks into lp:widelands/build19

2016-11-01 Thread SirVer
Review: Disapprove In my memory deadlocking AI was the norm in b17 and very frequent in b18. That people complain about it happening now in places is a sign that this has changed - which is a testament to Tibor's work! Great job! I think this is not such a big deal as people make it out to be.

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/prevent_ai_deadlocks into lp:widelands/build19

2016-11-01 Thread GunChleoc
The proposal to merge lp:~widelands-dev/widelands/prevent_ai_deadlocks into lp:widelands/build19 has been updated. Status: Needs review => Rejected For more details, see: https://code.launchpad.net/~widelands-dev/widelands/prevent_ai_deadlocks/+merge/309727 -- Your team Widelands Developers

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/prevent_ai_deadlocks into lp:widelands/build19

2016-11-01 Thread GunChleoc
Thanks for adding your experience to the issue. I'll be OK with not having it for Build 19. @Tibor: Don't feel bad, it's not your fault that nobody noticed until now! Listen to SirVer's well-deserved praise instead :) -- https://code.launchpad.net/~widelands-dev/widelands/prevent_ai_deadlocks/+

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/fsmenu_fullscreen_2_about into lp:widelands

2016-11-01 Thread GunChleoc
GunChleoc has proposed merging lp:~widelands-dev/widelands/fsmenu_fullscreen_2_about into lp:widelands. Commit message: The About menu now relayouts itself when fullscreen mode is toggled. Requested reviews: Widelands Developers (widelands-dev) Related bugs: Bug #1398733 in widelands: "Fulls

[Widelands-dev] [Merge] lp:~notabilis27/widelands/casern into lp:widelands

2016-11-01 Thread Notabilis
The proposal to merge lp:~notabilis27/widelands/casern into lp:widelands has been updated. Description changed to: Implements a worker queue which allows production buildings to consume workers as input. Adds: - Adds worker queue for production buildings. - The "inputs" in the lua files for the

[Widelands-dev] [Merge] lp:~notabilis27/widelands/casern into lp:widelands

2016-11-01 Thread Notabilis
Notabilis has proposed merging lp:~notabilis27/widelands/casern into lp:widelands. Requested reviews: Widelands Developers (widelands-dev) Related bugs: Bug #1075562 in widelands: "Implement a casern for soldier recruting" https://bugs.launchpad.net/widelands/+bug/1075562 For more details,

[Widelands-dev] [Merge] lp:~7010622-q/widelands/topple-production-logic-4 into lp:widelands

2016-11-01 Thread GunChleoc
The proposal to merge lp:~7010622-q/widelands/topple-production-logic-4 into lp:widelands has been updated. Commit Message changed to: Adjusted time values for weapon and armour production sites (all races) which were changed recently for more efficient use of their schemes. The new values are

Re: [Widelands-dev] [Merge] lp:~7010622-q/widelands/topple-production-logic-4 into lp:widelands

2016-11-01 Thread GunChleoc
@bunnybot merge -- https://code.launchpad.net/~7010622-q/widelands/topple-production-logic-4/+merge/309656 Your team Widelands Developers is requested to review the proposed merge of lp:~7010622-q/widelands/topple-production-logic-4 into lp:widelands.

[Widelands-dev] [Merge] lp:~7010622-q/widelands/topple-production-logic-4 into lp:widelands

2016-11-01 Thread noreply
The proposal to merge lp:~7010622-q/widelands/topple-production-logic-4 into lp:widelands has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~7010622-q/widelands/topple-production-logic-4/+merge/309656 -- Your team Widelands Developers is requ

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/innosetup_appid into lp:widelands

2016-11-01 Thread bunnybot
Continuous integration builds have changed state: Travis build 1552. State: passed. Details: https://travis-ci.org/widelands/widelands/builds/172272098. Appveyor build 1393. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_innosetup_

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/fsmenu_fullscreen_2_about into lp:widelands

2016-11-01 Thread bunnybot
Continuous integration builds have changed state: Travis build 1554. State: passed. Details: https://travis-ci.org/widelands/widelands/builds/172288018. Appveyor build 1394. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_fsmenu_ful

[Widelands-dev] [Merge] lp:~notabilis27/widelands/casern into lp:widelands

2016-11-01 Thread bunnybot
Continuous integration builds have changed state: Travis build 1556. State: failed. Details: https://travis-ci.org/widelands/widelands/builds/172322064. Appveyor build 1396. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_notabilis27_widelands_casern-1396.

[Widelands-dev] [Merge] lp:~notabilis27/widelands/bug-message-window into lp:widelands

2016-11-01 Thread GunChleoc
GunChleoc has proposed merging lp:~notabilis27/widelands/bug-message-window into lp:widelands. Commit message: Disable center button at once when message window is opened. Requested reviews: Widelands Developers (widelands-dev) Related bugs: Bug #1638409 in widelands: "Pressing "center" butt