Review: Resubmit
This should be ready now :)
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1543001-eris/+merge/291294
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1543001-eris.
___
Mailing list: h
Continuous integration builds have changed state:
Travis build 989. State: failed. Details:
https://travis-ci.org/widelands/widelands/builds/121769847.
Appveyor build 822. State: success. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_bug_1543001_
Can you also fix the issue I mentioned here:
https://code.launchpad.net/~widelands-dev/widelands/bug-1543001-eris/+merge/291294/comments/746462
This is what lead to the crash in the first place...
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1543001-eris/+merge/291294
Your team Wid
Sorry, I overlooked this one. Which message do you mean by "this message"? I
played the first tutorial through without any crashes.
> Besides the obvious error in Lua coroutine, there seems to be another issue
> with the message that is supposed to show up, which ultimately leads to a
> crash. Th
When a coroutine errors, an in-game message is supposed to be sent to all of
the players:
http://bazaar.launchpad.net/~widelands-dev/widelands/bug-1543001-eris/view/head:/src/logic/cmd_luacoroutine.cc#L51
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1543001-eris/+merge/291294
Your t
Bunnybot encountered an error while working on this merge proposal:
Running 'bzr pull --overwrite' failed. Output:
ssh: Could not resolve hostname bazaar.launchpad.net: No address associated
with hostname
ConnectionReset reading response for 'BzrDir.open_2.1', retrying
ssh: Could not resolve hos
Review: Approve testing
I have played some Tutorials and Campaigns, played a new game and also played
with the editor.
Works fine i think :-)
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1543001-eris/+merge/291294
Your team Widelands Developers is subscribed to branch
lp:~widelan
Continuous integration builds have changed state:
Travis build 993. State: passed. Details:
https://travis-ci.org/widelands/widelands/builds/122023836.
Appveyor build 826. State: success. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_bug_1543001_
This should now be fixed as well. It has been broken for ages.
> When a coroutine errors, an in-game message is supposed to be sent to all of
> the players:
> http://bazaar.launchpad.net/~widelands-
> dev/widelands/bug-1543001-eris/view/head:/src/logic/cmd_luacoroutine.cc#L51
--
https://code.laun
Continuous integration builds have changed state:
Travis build 994. State: passed. Details:
https://travis-ci.org/widelands/widelands/builds/122074637.
Appveyor build 827. State: failed. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_bug_1543001_e
Review: Approve code
LGTM.
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1543001-eris/+merge/291294
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1543001-eris.
___
Mailing list: https://launchpad.n
Thanks!
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1543001-eris/+merge/291294
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1543001-eris.
___
Mailing list: https://launchpad.net/
The proposal to merge lp:~widelands-dev/widelands/bug-1543001-eris into
lp:widelands has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/bug-1543001-eris/+merge/291294
--
Your team Widelands Developers is subscribed to
GunChleoc has proposed merging
lp:~widelands-dev/widelands/bug-1545243-plnum-lua into lp:widelands.
Commit message:
Some data type improvements:
- Fixed PlayerNumber datatype in Lua interface.
- New named datatype "Quantity" for ware/worker quantity.
- More consistent use of DescriptionIndex and
14 matches
Mail list logo
