Review: Approve
Code looks good, still want to play a bit with the Ports on
my https://wl.widelands.org/maps/fjord-ilands2/ map.
And some refactoring toward clean code is always good :-)
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1191556-cancel-expedition/+merge/288375
Your team
The proposal to merge lp:~widelands-dev/widelands/bug-1191556-cancel-expedition
into lp:widelands has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/bug-1191556-cancel-expedition/+merge/288375
--
Your team Widelands De
Thanks for testing :)
If you have any ideas concerning refactoring - I am all ears! We could open
bugs for those.
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1191556-cancel-expedition/+merge/288375
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands
GunChleoc has proposed merging lp:~widelands-dev/widelands/bug-1395278-map_io
into lp:widelands.
Commit message:
Refactored member variable names in src/map_io.
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #1395278 in widelands: "Consolidate naming of member vari
OK, I implemented the rest
--
https://code.launchpad.net/~widelands-dev/widelands/ai_roads_rework/+merge/288567
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/ai_roads_rework into lp:widelands.
_
Review: Approve
LGTM - just 1 more comment in the diff.
Diff comments:
> === modified file 'src/ai/ai_help_structs.cc'
> --- src/ai/ai_help_structs.cc 2016-02-18 17:58:54 +
> +++ src/ai/ai_help_structs.cc 2016-03-12 21:29:28 +
> @@ -300,6 +314,156 @@
> return (blocked_fields_.count
Or maybe base the value on the actual map dimensions? map.get_width() *
map.get_height()
--
https://code.launchpad.net/~widelands-dev/widelands/ai_roads_rework/+merge/288567
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/ai_roads_rework.
_
Review: Approve
Played this with a lot of Ports and about > 6 Expeditions for some 3 hours.
I found a Problem with the network lobby (crash if Computer went offline
during the game) but that cannot be related to this code.
Compiled it again, but found it is alreday in trunk.
I will stick to rev
8 matches
Mail list logo
