[Widelands-dev] Bunnybot says...

2016-01-20 Thread bunnybot
Travis build 307 has changed state to: passed. Details: https://travis-ci.org/widelands/widelands/builds/103335898. -- https://code.launchpad.net/~widelands-dev/widelands/resize_texture_cache/+merge/283048 Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-

[Widelands-dev] Bunnybot says...

2016-01-20 Thread bunnybot
Travis build 304 has changed state to: passed. Details: https://travis-ci.org/widelands/widelands/builds/103304106. -- https://code.launchpad.net/~widelands-dev/widelands/screenshot_from_backbuffer/+merge/283043 Your team Widelands Developers is requested to review the proposed merge of lp:~wide

[Widelands-dev] Bunnybot says...

2016-01-20 Thread bunnybot
Travis build 299 has changed state to: passed. Details: https://travis-ci.org/widelands/widelands/builds/103208245. -- https://code.launchpad.net/~widelands-dev/widelands/fix_editor_transparency_issue/+merge/282874 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/wideland

[Widelands-dev] Bunnybot says...

2016-01-20 Thread bunnybot
Travis build 300 has changed state to: passed. Details: https://travis-ci.org/widelands/widelands/builds/103208466. -- https://code.launchpad.net/~widelands-dev/widelands/stricter_travis/+merge/282852 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/stricter_tra

[Widelands-dev] Bunnybot says...

2016-01-20 Thread bunnybot
Travis build 310 has changed state to: passed. Details: https://travis-ci.org/widelands/widelands/builds/103434523. -- https://code.launchpad.net/~widelands-dev/widelands/ai_ship_tweaks/+merge/280192 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/ai_ship_tweak

[Widelands-dev] Bunnybot says...

2016-01-20 Thread bunnybot
Travis build 122 has changed state to: failed. Details: https://travis-ci.org/widelands/widelands/builds/99778652. -- https://code.launchpad.net/~widelands-dev/widelands/map_compatibility/+merge/276088 Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/

[Widelands-dev] Bunnybot says...

2016-01-20 Thread bunnybot
Travis build 124 has changed state to: failed. Details: https://travis-ci.org/widelands/widelands/builds/99784765. -- https://code.launchpad.net/~hjd/widelands/tests-poc/+merge/250533 Your team Widelands Developers is requested to review the proposed merge of lp:~hjd/widelands/tests-poc into lp:

[Widelands-dev] Bunnybot says...

2016-01-20 Thread bunnybot
Travis build 126 has changed state to: failed. Details: https://travis-ci.org/widelands/widelands/builds/99797556. -- https://code.launchpad.net/~widelands-dev/widelands/find_attack_soldiers/+merge/245276 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/find_att

[Widelands-dev] Bunnybot says...

2016-01-20 Thread bunnybot
Travis build 127 has changed state to: failed. Details: https://travis-ci.org/widelands/widelands/builds/99803809. -- https://code.launchpad.net/~widelands-dev/widelands/bug-1397500/+merge/243860 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1397500. ___

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/resize_texture_cache into lp:widelands

2016-01-20 Thread kaputtnik
Is there something special to look at? Runs fine. -- https://code.launchpad.net/~widelands-dev/widelands/resize_texture_cache/+merge/283048 Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/resize_texture_cache into lp:widelands. ___

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/resize_texture_cache into lp:widelands

2016-01-20 Thread SirVer
Not really you can click around a lot in the Map select dialogue, this will exercise the code - the cache will overflow and items will get dropped and put back in. -- https://code.launchpad.net/~widelands-dev/widelands/resize_texture_cache/+merge/283048 Your team Widelands Developers is req

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/disable_gl_depth into lp:widelands

2016-01-20 Thread SirVer
SirVer has proposed merging lp:~widelands-dev/widelands/disable_gl_depth into lp:widelands. Commit message: Disable GL_DEPTH testing for most operations and only enable it temporarily when everything is drawn onto the screen. Historically, WIdelands always implicitly defined the z-ordering by

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/screenshot_from_backbuffer into lp:widelands

2016-01-20 Thread TiborB
Review: Approve Works. Code LGTM -- https://code.launchpad.net/~widelands-dev/widelands/screenshot_from_backbuffer/+merge/283043 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/screenshot_from_backbuffer. ___ Mailing

[Widelands-dev] Bunnybot says...

2016-01-20 Thread bunnybot
Hi, I am bunnybot (https://github.com/widelands/bunnybot). I am keeping the source branch lp:~widelands-dev/widelands/disable_gl_depth mirrored to https://github.com/widelands/widelands/tree/_widelands_dev_widelands_disable_gl_depth You can give me commands by starting a line with @bunnybot . I

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/disable_gl_depth into lp:widelands

2016-01-20 Thread TiborB
Review: Approve I tested it, I noticed no issues -- https://code.launchpad.net/~widelands-dev/widelands/disable_gl_depth/+merge/283353 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/disable_gl_depth. ___ Mailing

[Widelands-dev] Bunnybot says...

2016-01-20 Thread bunnybot
Travis build 324 has changed state to: passed. Details: https://travis-ci.org/widelands/widelands/builds/103692405. -- https://code.launchpad.net/~widelands-dev/widelands/disable_gl_depth/+merge/283353 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/disable_gl_

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/screenshot_from_backbuffer into lp:widelands

2016-01-20 Thread SirVer
thanks! @bunnybot merge -- https://code.launchpad.net/~widelands-dev/widelands/screenshot_from_backbuffer/+merge/283043 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/screenshot_from_backbuffer. ___ Mailing list: h

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/disable_gl_depth into lp:widelands

2016-01-20 Thread SirVer
Thanks for testing and the review. Let's see if that fixes the Windows problem before merging it in. -- https://code.launchpad.net/~widelands-dev/widelands/disable_gl_depth/+merge/283353 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/disable_gl_depth. ___

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/ai_ship_tweaks into lp:widelands

2016-01-20 Thread SirVer
Really great work! That was not easy, but I think this design fits much better into the existing code. I think that reads much better than before. Last comment is about dealing with ship names. I suggest dealing with the string sets directly instead of indices into an array. Diff comments: >

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/screenshot_from_backbuffer into lp:widelands

2016-01-20 Thread noreply
The proposal to merge lp:~widelands-dev/widelands/screenshot_from_backbuffer into lp:widelands has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~widelands-dev/widelands/screenshot_from_backbuffer/+merge/283043 -- Your team Widelands Develope

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/ai_ship_tweaks into lp:widelands

2016-01-20 Thread TiborB
OK, I will move also remaining personality variables there then... I left one question in diff Diff comments: > > === modified file 'src/ai/defaultai.h' > --- src/ai/defaultai.h2016-01-06 19:11:20 + > +++ src/ai/defaultai.h2016-01-20 20:12:20 + > @@ -348,13 +349,16

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/rotate_terrains into lp:widelands

2016-01-20 Thread SirVer
SirVer has proposed merging lp:~widelands-dev/widelands/rotate_terrains into lp:widelands. Commit message: Fixes an error in converting from pixel space to opengl space which flipped all textures vertically when drawn on screen. Requested reviews: Widelands Developers (widelands-dev) Related

[Widelands-dev] Bunnybot says...

2016-01-20 Thread bunnybot
Hi, I am bunnybot (https://github.com/widelands/bunnybot). I am keeping the source branch lp:~widelands-dev/widelands/rotate_terrains mirrored to https://github.com/widelands/widelands/tree/_widelands_dev_widelands_rotate_terrains You can give me commands by starting a line with @bunnybot . I

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/resize_texture_cache into lp:widelands

2016-01-20 Thread TiborB
Review: Approve I think it can go... -- https://code.launchpad.net/~widelands-dev/widelands/resize_texture_cache/+merge/283048 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/resize_texture_cache. ___ Mailing list: h