Thanks for testing everybody! Thanks for reviewing, Tibor.
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/use_image_cache/+merge/282106
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/full_texture_atlas.
___
The proposal to merge lp:~widelands-dev/widelands/use_image_cache into
lp:widelands has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/use_image_cache/+merge/282106
--
Your team Widelands Developers is subscribed to br
Review: Resubmit
Thanks GunChleoc, i have adjusted the .
Browsers do mostly correct such misplaced things automatically, so it's not
easy to verify this during testing...
--
https://code.launchpad.net/~widelands-dev/widelands-website/iso_date_image_options/+merge/282653
Your team Widelands Dev
I cannot detect any visual regressions.
Still getting one "libpng warning: iCCP: known incorrect sRGB profile" on exit.
Any hint how to find the corresponding image?
--
https://code.launchpad.net/~widelands-dev/widelands/png_alternative_method/+merge/282856
Your team Widelands Developers is reques
Review: Resubmit
This grew a bit and needs another look.
--
https://code.launchpad.net/~widelands-dev/widelands/stricter_travis/+merge/282852
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/stricter_travis.
___
Maili
The proposal to merge lp:~widelands-dev/widelands/stricter_travis into
lp:widelands has been updated.
Commit Message changed to:
- Change warnings around switches: GCC no longer complains if a switch has no
default, clang complains if a switch that covers all cases has a default.
- Introduces a
It also fixed a real bug (removes wrong assert).
--
https://code.launchpad.net/~widelands-dev/widelands/stricter_travis/+merge/282852
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/stricter_travis.
___
Mailing list:
add a log("## %s", filename.c_str()) in load_image() in image_io I guess.
--
https://code.launchpad.net/~widelands-dev/widelands/png_alternative_method/+merge/282856
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/png_alternative_method int
Seems to be all ok. At least i haven't found any strange colored images in game
or editor yet. May i haven't checked all images. Some are also difficult to
compare with old status, because some images aren't shown correct also in
former revisions. So this isn't a result of this change.
I want t
Some of the workarea pics have lost transparency. F.e. pics/workarea123.png
which is used in the buildings menu.
The indicator for small buildings in buildhelp is darker -> pics/small.png
funnily enough pics/easy.png, which shows the same symbol, doesn't got darker.
--
https://code.launchpad.ne
Sorry the indicator for small buildings got not darker.
Tino, i couldn't see such messages anymore, even after exit. Have you run the
game with the "--datadir" option?
I have fixed the workarea oics and pushed the changes into this branch.
For now i couldn't find more wrong images. I want to ma
Review: Approve
Seems now all is good :-)
--
https://code.launchpad.net/~widelands-dev/widelands/png_alternative_method/+merge/282856
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/png_alternative_method.
___
Mailin
kaputtnik, as always thanks for testing :)
Tino, did you find a way to find the images with broken profile? If so, we
could revert this branch and only fix the ones that are broken - this would not
make this such a huge change for little gain (the size of most PNGs is < 1
block anyways, so shri
Review: Approve
No, sorry.
As a test, I've run "pngcrush -ow -rem allb -reduce" (compiled with gcc 5.3.0
and libpng 1.6.20) once more over all files does not change anything.
BZR then only shows changes on the three files kaputtnik comitted last, but
there is no visual difference.
Still 1-4 occu
They are not "broken" .. they have only a color profile which is unusual.
Almost images saving with adobe photoshop have such a profile.
In favor of reverting the branch, i would just correct them by hand with gimp
:-)
We should consider to remove images which are double. They needn't much spac
SirVer has proposed merging
lp:~widelands-dev/widelands/fix_editor_transparency_issue into lp:widelands.
Commit message:
- Fix transparency issues with representative_image().
- Refactor RenderTarget::drawanim(rect) into blit_animation and make
RenderTarget no longer depend on logic/ code.
Re
SirVer has proposed merging lp:~widelands-dev/widelands/fix_zip_filesystem into
lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/fix_zip_filesystem/+merge/282884
Fix deprecated use of implicit copy
The proposal to merge lp:~widelands-dev/widelands/fix_zip_filesystem into
lp:widelands has been updated.
Commit Message changed to:
Use std::shared_ptr to properly share zip files between classes.
ZipFilesystem, any child filesystems created by make_sub_file_system, and any
ZipStream[Write|Rea
Testers: This should be a refactoring only to make sure we are not broken by
c++14 (which deprecates our inproper use of Copy construction in this case). No
noticeable changes in behavior.
--
https://code.launchpad.net/~widelands-dev/widelands/fix_zip_filesystem/+merge/282884
Your team Widelands
> In favor of reverting the branch, i would just correct them by hand with gimp
> :-)
The problem is that we do not have a bullet proof way of figuring out which
ones are broken. Do you know one? If so, go for it and fix the PNGs and we can
drop this branch.
> We should consider to remove ima
Hi, I am bunnybot (https://github.com/widelands/bunnybot).
I am keeping the source branch
lp:~widelands-dev/widelands/fix_editor_transparency_issue mirrored to
https://github.com/widelands/widelands/tree/_widelands_dev_widelands_fix_editor_transparency_issue
You can give me commands by starting
Hi, I am bunnybot (https://github.com/widelands/bunnybot).
I am keeping the source branch lp:~widelands-dev/widelands/fix_zip_filesystem
mirrored to
https://github.com/widelands/widelands/tree/_widelands_dev_widelands_fix_zip_filesystem
You can give me commands by starting a line with @bunnybot
Travis build 293 has changed state to: passed. Details:
https://travis-ci.org/widelands/widelands/builds/10397.
--
https://code.launchpad.net/~widelands-dev/widelands/fix_editor_transparency_issue/+merge/282874
Your team Widelands Developers is requested to review the proposed merge of
lp:~w
Travis build 295 has changed state to: passed. Details:
https://travis-ci.org/widelands/widelands/builds/103019352.
--
https://code.launchpad.net/~widelands-dev/widelands/fix_zip_filesystem/+merge/282884
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-de
24 matches
Mail list logo
