When approving, please use the "Review" dropdown on the bottom. Setting it on
top hid this from view for some nebulous reason.
--
https://code.launchpad.net/~widelands-dev/widelands/spinbox/+merge/279153
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-de
This was another painful diff. I think it is looks good as usual. Please test
it somebody. From code point of view I approve it.
--
https://code.launchpad.net/~widelands-dev/widelands/ware_help/+merge/276516
Your team Widelands Developers is requested to review the proposed merge of
lp:~wideland
The proposal to merge lp:~widelands-dev/widelands/spinbox into lp:widelands has
been updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/spinbox/+merge/279153
--
Your team Widelands Developers is requested to review the proposed mer
I expect so - the old encyclopedia code was a bit hacky to make it work. Thanks
for the review :)
--
https://code.launchpad.net/~widelands-dev/widelands/ware_help/+merge/276516
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/ware_help into
I am not sure where the Ware help could be found :-S *lol*
Open the tribal help by hitting the questionmark on the bottom i found two
things:
1. The worker icon in the tab is the old icon. I think we should use the same
icons for workers in all menus. Somewhere i found also the old one, but i d
No that's it - the encyclopedia and the help accessed through the buildings. I
will fix and then post here again.
The German translation should be changed to "Kunde" or "Überlieferung" or
something - the English string is correct.
--
https://code.launchpad.net/~widelands-dev/widelands/ware_help
OK, images replaced.
The image I had used is pics/genstats_nrworkers.png, which is still used in the
general statistics, and in multiplayer setup to represent human players. Would
you like fixing these up in a new branch? I think the building icon could also
do with some more oomph now.
--
htt
I will test your changes tomorrow.
We should have an overlook on the whole icons i believe. I feel that there are
some icons which are either not used or could be replaced with other existing
icons... hm... time... give me time...
--
https://code.launchpad.net/~widelands-dev/widelands/ware_help
The proposal to merge lp:~widelands-dev/widelands/ware_help into lp:widelands
has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/ware_help/+merge/276516
--
Your team Widelands Developers is subscribed to branch
lp:~
Review: Approve
Looks good :-)
One thing: In the wares help and in workers help the deep mines comes before
mines. F.e. for ware "coal"
I will approve nevertheless. You could self decide if you want to fix this in
here.
--
https://code.launchpad.net/~widelands-dev/widelands/ware_help/+merge/2
10 matches
Mail list logo
