Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1291904 into lp:widelands

2015-06-03 Thread GunChleoc
I can reproduce this now. It also doesn't happen in trunk, so the bug is in this branch. -- https://code.launchpad.net/~widelands-dev/widelands/bug-1291904/+merge/237128 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1291904. _

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/authors into lp:widelands

2015-06-03 Thread GunChleoc
> you are removing a lot of translator_credits/*.po files but there are only 2 > translators/*.json files, why? Because I don't want to have to keep comparing the data while this branch is waiting for merging. I will copy the data over in Transifex when we've merged this. Transifex will then auto

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/authors into lp:widelands

2015-06-03 Thread TiborB
Review: Approve I don't know what exactly Transifex is but if you personally guarantee that the information will be added later, I am fine with it. I tested it of course, it looks good... -- https://code.launchpad.net/~widelands-dev/widelands/authors/+merge/250513 Your team Widelands Developers

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1399621 into lp:widelands

2015-06-03 Thread GunChleoc
GunChleoc has proposed merging lp:~widelands-dev/widelands/bug-1399621 into lp:widelands. Requested reviews: Widelands Developers (widelands-dev) Related bugs: Bug #849705 in widelands: "Add a column for "stopped" buildings in building statistics" https://bugs.launchpad.net/widelands/+bug/

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1399621 into lp:widelands

2015-06-03 Thread GunChleoc
I had overlooked the diff question. The checks only check for the exact object type without inheritance, so I have to teat for all 3 types explicitly. Diff comments: > === modified file 'src/wui/building_statistics_menu.cc' > --- src/wui/building_statistics_menu.cc 2014-11-30 18:49:38 +000