[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1399621 into lp:widelands

2015-05-12 Thread GunChleoc
GunChleoc has proposed merging lp:~widelands-dev/widelands/bug-1399621 into lp:widelands. Requested reviews: Widelands Developers (widelands-dev) Related bugs: Bug #849705 in widelands: "Add a column for "stopped" buildings in building statistics" https://bugs.launchpad.net/widelands/+bug/

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/building_encyclopedia into lp:widelands

2015-05-12 Thread GunChleoc
Do you remember where you were when that happened? What was the last help entry you clicked at? These errors can be triggered when a Lua variable isn't declared as local, but I can't find any. This particular error seems to be a malformed bformat string - bformat is our Lua wrapper for boost::

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1418050 into lp:widelands

2015-05-12 Thread GunChleoc
GunChleoc has proposed merging lp:~widelands-dev/widelands/bug-1418050 into lp:widelands. Requested reviews: Widelands Developers (widelands-dev) Related bugs: Bug #1418050 in widelands: "Secondary and Third Alternative Tool no longer reset to the first tool if you let go of the button" ht

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1418050 into lp:widelands

2015-05-12 Thread GunChleoc
The proposal to merge lp:~widelands-dev/widelands/bug-1418050 into lp:widelands has been updated. Description changed to: Added handling of SDL_KEYUP event. This fixes that the editor did not return to the first tool when SHIFT or ALT etc. was released. DO NOT set the bug to "Fix Committed", w

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/building_encyclopedia into lp:widelands

2015-05-12 Thread TiborB
No, I was doing something else and when I returned to widelands - it was crashed. So I really dont remember how I left the game. If you feel so, go on and merge this, if the problem is critical it will be found and reported. Especially if this is not related to new code. -- https://code.launchp

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1451147 into lp:widelands

2015-05-12 Thread GunChleoc
Review: Approve LGTM :) -- https://code.launchpad.net/~widelands-dev/widelands/bug-1451147/+merge/258812 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1451147. ___ Mailing list: https://launchpad.net/~widelands

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1418050 into lp:widelands

2015-05-12 Thread TiborB
Review: Approve It seems it fixed the issue. I think you can merge this -- https://code.launchpad.net/~widelands-dev/widelands/bug-1418050/+merge/258913 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1418050. __

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1451147 into lp:widelands

2015-05-12 Thread noreply
The proposal to merge lp:~widelands-dev/widelands/bug-1451147 into lp:widelands has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~widelands-dev/widelands/bug-1451147/+merge/258812 -- Your team Widelands Developers is subscribed to branch lp

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1442869 into lp:widelands

2015-05-12 Thread GunChleoc
Review: Approve LGTM :) -- https://code.launchpad.net/~widelands-dev/widelands/bug-1442869/+merge/258203 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1442869. ___ Mailing list: https://launchpad.net/~widelands

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/building_encyclopedia into lp:widelands

2015-05-12 Thread GunChleoc
OK, I will merge this then. Thanks for the review :) -- https://code.launchpad.net/~widelands-dev/widelands/building_encyclopedia/+merge/258719 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/building_encyclopedia. __

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1418050 into lp:widelands

2015-05-12 Thread noreply
The proposal to merge lp:~widelands-dev/widelands/bug-1418050 into lp:widelands has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~widelands-dev/widelands/bug-1418050/+merge/258913 -- Your team Widelands Developers is subscribed to branch lp

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/building_encyclopedia into lp:widelands

2015-05-12 Thread noreply
The proposal to merge lp:~widelands-dev/widelands/building_encyclopedia into lp:widelands has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~widelands-dev/widelands/building_encyclopedia/+merge/258719 -- Your team Widelands Developers is subs

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1442869 into lp:widelands

2015-05-12 Thread noreply
The proposal to merge lp:~widelands-dev/widelands/bug-1442869 into lp:widelands has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~widelands-dev/widelands/bug-1442869/+merge/258203 -- Your team Widelands Developers is subscribed to branch lp:~wi