Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/empire into lp:widelands

2015-04-25 Thread GunChleoc
No problem. Thanks for the review - things can't be proofread too often :) -- https://code.launchpad.net/~widelands-dev/widelands/empire/+merge/257141 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/empire. ___ Mailin

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/find_attack_soldiers into lp:widelands

2015-04-25 Thread GunChleoc
Can you create a bug report for this, so we can take care of it in a separate branch? I have worked with signals before on the UI and might be able to figure it out, so I would put it on my todo-list. -- https://code.launchpad.net/~widelands-dev/widelands/find_attack_soldiers/+merge/245276 Your

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1390793 into lp:widelands

2015-04-25 Thread GunChleoc
Why don't you try having a look at the code? I don't understand all the GL stuff SirVer is doing either, but I review it anyway, because there is no-one else to do it. Granted, this branch might be a bit too big to start doing your first code review. 1. The seafaring checkbox is for the filter

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/find_attack_soldiers into lp:widelands

2015-04-25 Thread Martin Schmidt
I will create a bug report as soon as this branch is merged. -- https://code.launchpad.net/~widelands-dev/widelands/find_attack_soldiers/+merge/245276 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/find_attack_soldiers.

[Widelands-dev] [Merge] lp:~hjd/widelands/codecheck-and-deduplication into lp:widelands

2015-04-25 Thread Hans Joachim Desserud
Hans Joachim Desserud has proposed merging lp:~hjd/widelands/codecheck-and-deduplication into lp:widelands. Requested reviews: Widelands Developers (widelands-dev) For more details, see: https://code.launchpad.net/~hjd/widelands/codecheck-and-deduplication/+merge/257464 I started looking at a