The last 2 commits are NOCOM(#sirver) comments that need attention.
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1074353/+merge/221095
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1074353.
___
Mai
The proposal to merge lp:~widelands-dev/widelands/bug-1074353 into lp:widelands
has been updated.
Description changed to:
This is in a mergeable state now, although more work needs to be done, as
commented in the source code (comments are in lua_map.cc and format_help.lua).
The remaining issue
GunChleoc has proposed merging lp:~widelands-dev/widelands/bug-1339861 into
lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #1339861 in widelands: "Remove the "Military settings" option"
https://bugs.launchpad.net/widelands/+bug/1339861
For more deta
SirVer has proposed merging lp:~widelands-dev/widelands/map_information into
lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/map_information/+merge/226572
Suggested submit message:
-
- Add a
Review: Needs Fixing
It annoys me telling you the same things again (like not including SDL_types.h
which I think I did two times before or removing the Default AI comment)
but I will do it one more time. This time I did it as inline comments, so that
it will not get lost in the review proc
Review: Approve
--
https://code.launchpad.net/~widelands-dev/widelands/world-stringfix/+merge/226426
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/world-stringfix.
___
Mailing list: https://launchpad.net/~wideland
The proposal to merge lp:~widelands-dev/widelands/world-stringfix into
lp:widelands has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/world-stringfix/+merge/226426
--
https://code.launchpad.net/~widelands-dev/wideland
The proposal to merge lp:~widelands-dev/widelands/rtl-reverse-gui into
lp:widelands has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/rtl-reverse-gui/+merge/220863
--
https://code.launchpad.net/~widelands-dev/wideland
Review: Approve
Oversight on my part. Thanks for catching this.
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1339861/+merge/226570
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1339861.
___
Maili
The proposal to merge lp:~widelands-dev/widelands/bug-1339861 into lp:widelands
has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/bug-1339861/+merge/226570
--
https://code.launchpad.net/~widelands-dev/widelands/bug-13
The proposal to merge lp:~widelands-dev/widelands/bug-1293158 into lp:widelands
has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/bug-1293158/+merge/221434
--
https://code.launchpad.net/~widelands-dev/widelands/bug-12
the problem was that number of players is a uchar (i.e. 0 <= uchar <= 255).
Boost::format() likes to interpret this though as a 'single char'. I merged
this and static_cast() the value in question and all is good.
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1293158/+merge/221434
Cool! Merged in r 7074.
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1324137/+merge/221353
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1324137.
___
Mailing list: https://launchpad.net/~widelands-
The proposal to merge lp:~widelands-dev/widelands/bug-1324137 into lp:widelands
has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/bug-1324137/+merge/221353
--
https://code.launchpad.net/~widelands-dev/widelands/bug-13
what happens with this branch now, hjd?
--
https://code.launchpad.net/~widelands-dev/widelands/freebsd/+merge/225867
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/freebsd into lp:widelands.
___
Sounds interesting, and it definitely sounds like a good idea to have a
single(, working) implementation for how maps are drawn. Could you give some
more details on how you see this being handled on the website-side, and what
will be needed there?
Does this handle old (separate world) maps too?
GunChleoc has proposed merging lp:~widelands-dev/widelands/rename_goldweaver
into lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/rename_goldweaver/+merge/226580
Renamed a building to make more se
Thanks :)
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1293158/+merge/221434
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1293158.
___
Mailing list: https://launchpad.net/~widelands-dev
Post to
* State: Failed to build
* Recipe: widelands-dev/widelands-daily
* Archive: ~widelands-dev/ubuntu/widelands-daily
* Distroseries: saucy
* Duration: 5 minutes
* Build Log:
https://launchpad.net/~widelands-dev/+archive/widelands-daily/+recipebuild/754483/+files/buildlog.txt.gz
* Upload Log:
GunChleoc has proposed merging lp:~widelands-dev/widelands/bug-1341112 into
lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #1341112 in widelands: "Editor line abruption in Noise height tool"
https://bugs.launchpad.net/widelands/+bug/1341112
For more
GunChleoc has proposed merging lp:~widelands-dev/widelands/fix_world_names into
lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/fix_world_names/+merge/226592
Some of the skeletons are actually sea
All right you probably said it, I am not arguing...
two comments to latest revision:
a) animation.cc - I reverted this file to status in trunk, I am not able to
fix it properly, I just needed to prevent crashes when testing AI
b) in regard to this:
NOCOM(#tiborb): move this safe_ware_index() to
Ferdinand T. has proposed merging lp:~f-thiessen/widelands/bug-1307844 into
lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
For more details, see:
https://code.launchpad.net/~f-thiessen/widelands/bug-1307844/+merge/226596
Fixed Bug 1307844 - Enhancement-system
Tested wit
23 matches
Mail list logo
