Hi All,
I tried to build widelands (trunk) on debian lenny with clang and run into
two problems:
first:
src/logic/widelands.h:68:19: error: constexpr variable 'INVALID_INDEX' must
be initialized by a constant
expression
constexpr uint8_t INVALID_INDEX = std::numeric_limits::max();
It was
>
> src/logic/widelands.h:68:19: error: constexpr variable 'INVALID_INDEX' must
> be initialized by a constant
> expression
> constexpr uint8_t INVALID_INDEX = std::numeric_limits::max();
>
seems like you are not using the http://libcxx.llvm.org/ which you should
always use with clang. I
I have installed:
ii clang1:3.0-6.2
i386 Low-Level Virtual Machine (LLVM), C language
family frontend
ii clang-format-3.5 1:3.5~svn198086-1~exp1
i386 Tool to format C/C++/Obj-C code
ii libclang-common
Oh, I appologize: Debian 7 = Wheezy
And yes, with gcc it compiles flawlessly
2014-06-16 15:37 GMT+02:00 Teppo Maenpaa :
> On Mon, Jun 16, 2014 at 12:11:04PM +0200, Tibor Bamhor wrote:
>
> I tried to build widelands (trunk) on debian lenny with clang and run into
>> two problems:
>>
>
> Can y
On Mon, Jun 16, 2014 at 12:11:04PM +0200, Tibor Bamhor wrote:
I tried to build widelands (trunk) on debian lenny with clang and run into
two problems:
Can you compile it using the gnu compiler collection?
Lenny is rather old; released in February 2009, support ended in 2012.
and second pro
Cool! I think it is easiest to just litter the code with NOCOMMIT(#sirver) or
something greppable. I can then take a look at those things.
--
https://code.launchpad.net/~widelands-dev/widelands/one_world/+merge/222708
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/wid
Inline comments are fine too, of course.
--
https://code.launchpad.net/~widelands-dev/widelands/one_world/+merge/222708
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/one_world.
___
Mailing list: https://launchpad.ne
I changed some formatting issues and small obvious errors. I also changed
documentation to doxygen comment style so it gets picked up.
Here are the remaining questions:
- Why did you hard code the compiler in compile.sh
- Why are critter sound_effect split in directory and name and not just a pat
Thanks for the review! It is very much appreciated. You also caught some bugs
that I have missed. Code reviews are such an awesome thing! nearly as good as
pair programming.
> - Why did you hard code the compiler in compile.sh
good catch. gun did that and probably submitted the change by accide
9 matches
Mail list logo
