[Widelands-dev] [Merge] lp:~widelands-dev/widelands/handle_tab into lp:widelands

2014-03-05 Thread Tino
Tino has proposed merging lp:~widelands-dev/widelands/handle_tab into lp:widelands. Requested reviews: Widelands Developers (widelands-dev) Related bugs: Bug #1232392 in widelands: "Allow tabbing in forms" https://bugs.launchpad.net/widelands/+bug/1232392 For more details, see: https://cod

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/handle_tab into lp:widelands

2014-03-05 Thread Shevonar
Review: Needs Fixing I just noticed a little misinterpretation: case SDLK_KP_ENTER is actually not an empty switch case. It just falls through to case SDLK_RETURN to handle the Enter key on the keypad the same way as the Return key. A case is only redundant if it falls through to the default ca

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/handle_tab into lp:widelands

2014-03-05 Thread Tino
You are right, i've put back that case distinction. -- https://code.launchpad.net/~widelands-dev/widelands/handle_tab/+merge/209406 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/handle_tab. ___ Mailing list: https:/

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/i18n into lp:widelands

2014-03-05 Thread noreply
The proposal to merge lp:~widelands-dev/widelands/i18n into lp:widelands has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~widelands-dev/widelands/i18n/+merge/209212 -- https://code.launchpad.net/~widelands-dev/widelands/i18n/+merge/209212 Y

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/gci18nfixes into lp:widelands

2014-03-05 Thread SirVer
We merged the i18n branch - so this merge request is superseeded by this merge and therefore rejected. -- https://code.launchpad.net/~widelands-dev/widelands/gci18nfixes/+merge/192288 Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/gci18nfi

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/gci18nfixes into lp:widelands

2014-03-05 Thread SirVer
The proposal to merge lp:~widelands-dev/widelands/gci18nfixes into lp:widelands has been updated. Status: Needs review => Rejected For more details, see: https://code.launchpad.net/~widelands-dev/widelands/gci18nfixes/+merge/192288 -- https://code.launchpad.net/~widelands-dev/widelands/gci1

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/handle_tab into lp:widelands

2014-03-05 Thread SirVer
Review: Approve lgtm. -- https://code.launchpad.net/~widelands-dev/widelands/handle_tab/+merge/209406 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/handle_tab. ___ Mailing list: https://launchpad.net/~widelands-de

[Widelands-dev] [recipe build #666256] of ~widelands-dev widelands-daily-precise in precise: Failed to build

2014-03-05 Thread noreply
* State: Failed to build * Recipe: widelands-dev/widelands-daily-precise * Archive: widelands-dev/widelands-daily-precise * Distroseries: precise * Duration: 4 minutes * Build Log: https://launchpad.net/~widelands-dev/+archive/widelands-daily-precise/+recipebuild/666256/+files/buildlog.txt.g