As a reminder to myself, should this get merged:
- replace all scoped_ptr and most shared_ptr through unique_ptrs.
- replace all boost::foreach with for( a : b) interations.
--
https://code.launchpad.net/~widelands-dev/widelands/cxx11/+merge/175455
Your team Widelands Developers is requested to r
Shevonar has proposed merging lp:~shevonar/widelands-website/bug1202301 into
lp:widelands-website.
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #1202301 in Widelands Website: "Some maps not accepted by Map upload"
https://bugs.launchpad.net/widelands-website/+bu
The proposal to merge lp:~shevonar/widelands-website/bug1202301 into
lp:widelands-website has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~shevonar/widelands-website/bug1202301/+merge/175470
--
https://code.launchpad.net/~shevonar/widelands
The proposal to merge lp:~hjd/widelands/scan-build-cmake into lp:widelands has
been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~hjd/widelands/scan-build-cmake/+merge/175269
--
https://code.launchpad.net/~hjd/widelands/scan-build-cmake/+merge/17
Hans Joachim Desserud has proposed merging lp:~hjd/widelands/prodsite-null into
lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
For more details, see:
https://code.launchpad.net/~hjd/widelands/prodsite-null/+merge/175538
Found by scan-build. I believe this should fix the
Any estimate which compiler versions this change would require at a minimum?
I realize that a) we can't support ancient releases forever and b) a new
release will mainly be packaged in development versions where newer compilers
will be available anyways. Still, we have things like the PPA for s
cghislai has proposed merging lp:~widelands-dev/widelands/bug657285 into
lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/bug657285/+merge/175551
I corrected the bug by handling mousein events in t
On Wed, Jul 17, 2013 at 07:44:40AM +0200, Holger Rapp wrote:
No, I do not think you are correct here. There is so much difference in the
way people can or cannot perceive color. Brightness doesn't seem to be
easily order-able for a human and the differences are harder to perceive.
Hi,
You ar
Hans Joachim Desserud has proposed merging lp:~hjd/widelands/string-fixes into
lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
For more details, see:
https://code.launchpad.net/~hjd/widelands/string-fixes/+merge/175595
Fixes and improvements for various strings. See indi
I add I feel sorry for all regressions linked to my code. I will fixes them all
asap. Those linked to opengl rendering may be tricky.
--
https://code.launchpad.net/~widelands-dev/widelands/bug657285/+merge/175551
Your team Widelands Developers is requested to review the proposed merge of
lp:~wid
Review: Approve
I also approve this to be merged as I need this code to be able to spot issues
related to opengl rendering.
--
https://code.launchpad.net/~widelands-dev/widelands/graphic_resetting/+merge/159985
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/g
SirVer has proposed merging lp:~widelands-dev/widelands/graphic_resetting into
lp:widelands.
Requested reviews:
Tino (tino79)
Related bugs:
Bug #1159968 in widelands: "Crash in opengl fonthandler_cc:99"
https://bugs.launchpad.net/widelands/+bug/1159968
For more details, see:
https://code.l
cghislai has proposed merging lp:~widelands-dev/widelands/boost_static_assert
into lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/boost_static_assert/+merge/175607
This get rid of compile_assert.
I am currently Sending a branch using c++11 static_assert for review. Feel free
to comment and review this :)
--
https://code.launchpad.net/~widelands-dev/widelands/boost_static_assert/+merge/175607
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/wid
Indeed, I missed that. I noticed however than even with this fix the table is
not updating in current trunk. I will push a new branch with the complete fix.
--
https://code.launchpad.net/~hjd/widelands/prodsite-null/+merge/175538
Your team Widelands Developers is requested to review the proposed
cghislai has proposed merging lp:~widelands-dev/widelands/workers_table into
lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/workers_table/+merge/175635
Fix the workers table.
Besides the fix of H
https://code.launchpad.net/~widelands-dev/widelands/workers_table/+merge/175635
--
https://code.launchpad.net/~hjd/widelands/prodsite-null/+merge/175538
Your team Widelands Developers is requested to review the proposed merge of
lp:~hjd/widelands/prodsite-null into lp:widelands.
Yes i fetched that already for testing. I started to compile but I leave now, i
will test in a few hours.
--
https://code.launchpad.net/~widelands-dev/widelands/boost_static_assert/+merge/175607
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelan
The proposal to merge lp:~hjd/widelands/prodsite-null into lp:widelands has
been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~hjd/widelands/prodsite-null/+merge/175538
--
https://code.launchpad.net/~hjd/widelands/prodsite-null/+merge/175538
Your
The proposal to merge lp:~widelands-dev/widelands/workers_table into
lp:widelands has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/workers_table/+merge/175635
--
https://code.launchpad.net/~widelands-dev/widelands/wo
This is contained in charlys branch as well, so this is kinda merged. Thanks
for finding this!
--
https://code.launchpad.net/~hjd/widelands/prodsite-null/+merge/175538
Your team Widelands Developers is requested to review the proposed merge of
lp:~hjd/widelands/prodsite-null into lp:widelands.
Review: Approve
LGTM. Merged.
--
https://code.launchpad.net/~widelands-dev/widelands/workers_table/+merge/175635
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/workers_table.
___
Mailing list: https://launchpad.net/
Review: Needs Fixing
do not worry - you add code at a tremendous rate and WL has no test suite
(well, only the Lua test suite which tests quite a bit of code actually. And
the new rich text renderer). So regressions do happen.
I can have a look at the OpenGL ones too - it might be as trivial as
The proposal to merge lp:~widelands-dev/widelands/graphic_resetting into
lp:widelands has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/graphic_resetting/+merge/159985
--
https://code.launchpad.net/~widelands-dev/wide
On 18.07.2013, at 15:31, Teppo Maenpaa wrote:
> On Wed, Jul 17, 2013 at 07:44:40AM +0200, Holger Rapp wrote:
>
>> No, I do not think you are correct here. There is so much difference in the
>> way people can or cannot perceive color. Brightness doesn't seem to be
>> easily order-able for a hu
This should compile nicely in GCC 4.3 I think (which was released in March 5,
2008). Looking over http://gcc.gnu.org/projects/cxx0x.html would make me think
that we could get by with GCC 4.5 for a while - we would gradually adopt c++ 11
features into the code base. I have no idea about clang (bu
Indeed it compiled fine on my linux gcc 4.8.1. And without a warning (well, 1).
If this is merged my branch about BOOST_STATIC_ASSERT could be dropped.
I think widelands has always been a stable product - please allow me to
reiterate my apologies concerning the ui_improvement fixes that introduc
Review: Approve
You are right, I was quite in a hurry to correct those bugs and the solutions I
proposed here weren't by far the optimal ones.
I saw that escaping <> characters were supported. I first went for that then
for some reason thought it would be best to handle that at the source direc
Review: Abstain
--
https://code.launchpad.net/~widelands-dev/widelands/bug657285/+merge/175551
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug657285.
___
Mailing list: https://launchpad.net/~widelands-dev
Post t
About the tooltips: I think it should be another event. So, when the UI decides
that it would like to show a tooltip, it calls "OnTooltip" or so on the current
panels (very similar to how mousein behaves) and each of them can report with
"true" to set the tooltip or false to pass on to the next
A first quick test: It does not compile on mingw32 with gcc 4.7.2.
At the beginning, gcc fails to find an include (mman.h) in basic_fileread.h:
#ifdef WIN32
#else
#include
#endif
I am completely lost why, because:
- it does not differ from trunk
- it is the else case => should not be
31 matches
Mail list logo
