protocol looks good to me. I would just suggest using static const
std::string = "COMMANDNAME". #defines are not typesafe and have no
benefits in this case (IMHO). Otherwise the protocol looks good to me. I
am also pro ignoring translation of motd and therelike. The other
messages should imho be te
alright I will change the strings to static const std::string
IGPCMD_LOGIN = "LOGIN"; etc.
about the testsuite:
unfortunally the InternetGaming class is not *that* much "standalone" - it at
least needs the network code for sending and receiving data packages + it has
to be a chat controller (we
okay.
Changes to the protocol are in the branch, as well as my initial version
of InternetGamingMessages - mini class that returns a translated string
for a message code from the metaserver like "WRONG_PASSWORD". Any
comments on that?
--
You received this bug notification because you are a membe
Borim has proposed merging lp:~borim/widelands/bug590631 into lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #590631 in widelands: "All workers die, when warehouse/hq is destroyed"
https://bugs.launchpad.net/widelands/+bug/590631
For more details, se
As I said, I wasn't sure how easy it would be. It just seemed like a
nice opportunity to add tests to one of the important components. Like
SirVer mentioned, I imagined something like running a local server and
seeing if that responds in the expected way would be the easist way.
(Mocking [1] might
5 matches
Mail list logo
