Re: [Widelands-dev] coverity scan issue

2015-05-05 Thread Fòram na Gàidhlig
Thanks for the screenshot you sent me. Looking at trunk, EnemySiteObserver has 2 booleans for the warehouse: 459 bool warehouse_; 466 bool warehouse; One of them needs to go. This probably happened sometime due to reordering and then merging stuff. "defenders" is indeed not initialized

[Widelands-dev] coverity scan issue

2015-05-04 Thread Tibor Bamhor
When I looked at this: https://scan4.coverity.com/reports.htm#v12668/p10285/fileInstanceId=1968592&defectInstanceId=605921&mergedDefectId=64815 I found a peculiar thing. Compare lines 466 and 471 - how is it possible that "_" is missing on line 466? In current trunk in both lines contains "ware