The proposal to merge lp:~widelands-dev/widelands/python3 into lp:widelands has
been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/python3/+merge/291236
--
Your team Widelands Developers is subscribed to branch
lp:~widela
Review: Approve
I cannot imagine why Python3 should be slower, because it is a very simple
script and all test computing is done by the widelands binary. I am pretty sure
if you would do another run with Python 3 it should be equally fast (perhaps
your OS or your harddisk caches, or something
Review: Approve review / test / compile
$ ./regression_test.py -b ./widelands ; ## thats Python 3.4.4
Ran 32 tests in 1018.389s
$ python2.7 ./regression_test.py -b ./widelands
...
Ran 32 tests in 616.502s
Works but Python 3.4.4 was much slower.
Well I used this first so all files where cached
Continuous integration builds have changed state:
Travis build 985. State: passed. Details:
https://travis-ci.org/widelands/widelands/builds/121622180.
Appveyor build 818. State: success. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_python3-818.
Review: Approve
It's working for me now :)
--
https://code.launchpad.net/~widelands-dev/widelands/python3/+merge/291236
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/python3.
___
Mailing list: https://launchpad.net
Review: Resubmit
Ok, please have another look on linux.
--
https://code.launchpad.net/~widelands-dev/widelands/python3/+merge/291236
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/python3.
___
Mailing list: https://
Continuous integration builds have changed state:
Travis build 980. State: errored. Details:
https://travis-ci.org/widelands/widelands/builds/121409569.
Appveyor build 813. State: success. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_python3-813
On my system. this will start the Widelands main screen for each test instead
of going to the scenario. Python 2.7
--
https://code.launchpad.net/~widelands-dev/widelands/python3/+merge/291236
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/python3.
___
Review: Needs Fixing
Hm, I did run the test with both Python 2/3 without these errors, but perhaps I
aborted them too early.
Or the test do not currently run on windows?
I'll check this later today...
--
https://code.launchpad.net/~widelands-dev/widelands/python3/+merge/291236
Your team Widelan
Mhh, even using python 2.7 does not work, it just gets stuck in the splasg
screeen?
Was there some change in the Lua Binding?
--
https://code.launchpad.net/~widelands-dev/widelands/python3/+merge/291236
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev
OK, thas as far as I came, too but now I get
$ ./regression_test.py -b ./widelands
...
File "./regression_test.py", line 103, in run_widelands
stdout_file.write(line)
TypeError: must be str, not bytes
I used
print(line, flush=True)
for
stdout_file.write(line)
stdout_file.flush()
but
Looks like you know more about python than I do,
lets check this ...
--
https://code.launchpad.net/~widelands-dev/widelands/python3/+merge/291236
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/python3 into lp:widelands.
___
Tino has proposed merging lp:~widelands-dev/widelands/python3 into lp:widelands.
Commit message:
Add a compatibility layer to regression_test.py to allow running with python 2
and 3
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #1566876 in widelands: "regression_t
The proposal to merge lp:~widelands-dev/widelands/python3 into lp:widelands has
been updated.
Commit Message changed to:
Add a compatibility layer to regression_test.py to allow running with python 2
and 3
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/python3/+merg
14 matches
Mail list logo
