Pushed to trunk.
I've updated
https://wl.widelands.org/wiki/TranslationDictionaryTemplate/
and
https://wl.widelands.org/wiki/Terminology%20Correspondence%20Table/
--
https://code.launchpad.net/~widelands-dev/widelands/furnace/+merge/227810
Your team Widelands Developers is subscribed to branch
l
The proposal to merge lp:~widelands-dev/widelands/furnace into lp:widelands has
been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/furnace/+merge/227810
--
https://code.launchpad.net/~widelands-dev/widelands/furnace/+merge
Review: Approve
LGTM
--
https://code.launchpad.net/~widelands-dev/widelands/furnace/+merge/227810
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/furnace.
___
Mailing list: https://launchpad.net/~widelands-dev
Post t
>the # operator means length in lua.
Aha, so that's what it does.
> Ie. rv["well"] is the same as rv.well
Hm, like Javascript then.
Think that should be all then.
--
https://code.launchpad.net/~widelands-dev/widelands/furnace/+merge/227810
Your team Widelands Developers is subscribed to branch
tl;dr: yes, your assumption is correct.
longer:
local rv = plr:get_buildings{"well", "burners_house"}
returns a lua table of tables (see
https://wl.widelands.org/docs/wl/autogen_wl_game/#wl.game.Player.get_buildings).
It will therefore return { "well": { b1,b2}, "burners_house": { b1}} and so o
I think a way to test this would be to play the 2nd Empire campaign until you
hit the objective "obj_better_material_2". Then don't build any coal mines but
charcoal kilns only and see if you can complete the objectve by that. If you
can, everything's fine.
--
https://code.launchpad.net/~widela
I'm not that familiar with lua, so I would like someone to doublecheck my
assumptions.
I see that the code calls
local rv = plr:get_buildings{"well", "burners_house"}
The way I've interpreted this is that it gives me a map which contains building
names as the keys and the amount of those buildi
Sorry. I missed the question in the code and now that I found it, I do not
understand what you mean by it. Can you elaborate a bit more?
--
https://code.launchpad.net/~widelands-dev/widelands/furnace/+merge/227810
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands
I'd like a reply to the TODO comment/question.
Other than that, Gun Chleoc has approved to the changes a couple of comments up.
--
https://code.launchpad.net/~widelands-dev/widelands/furnace/+merge/227810
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/furna
What is this waiting on?
--
https://code.launchpad.net/~widelands-dev/widelands/furnace/+merge/227810
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/furnace.
___
Mailing list: https://launchpad.net/~widelands-dev
Pos
Unsurprisingly, nothing in scripting. I checked tribes when changing the
names/moving directories.
--
https://code.launchpad.net/~widelands-dev/widelands/furnace/+merge/227810
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/furnace.
___
grep the tribes and scripting as well, just to make sure. Otherwise, +1 from me
once your todo comment has been resolved.
--
https://code.launchpad.net/~widelands-dev/widelands/furnace/+merge/227810
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/furnace.
>Have you grepped for burner/Burner to make sure that you've caught them all?
Replaced the use of burner in maps and campaigns now. Any other places I need
to check?
--
https://code.launchpad.net/~widelands-dev/widelands/furnace/+merge/227810
Your team Widelands Developers is subscribed to branc
Review: Needs Fixing
I had a look at the diff without testing and added some comments for small
string fixes.
Have you grepped for burner/Burner to make sure that you've caught them all?
I can't answer your todo question right now, since I'm not familiar with
scenario code.
Diff comments:
>
Review: Resubmit
Let's try again.
Renamed charcoal burner/burner's house to Charcoal Kiln, and burner (the
worker) to Charcoal Burner.
Remaining:
I have a TODO comment with a question, and the translation table on the wiki
needs to be updated once/when this lands.
--
https://code.launchpad.ne
Let's go with it. Sorry about the confusion + extra work
--
https://code.launchpad.net/~widelands-dev/widelands/furnace/+merge/227810
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/furnace into lp:widelands.
___
Review: Approve
Agreed
--
https://code.launchpad.net/~widelands-dev/widelands/furnace/+merge/227810
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/furnace into lp:widelands.
___
Mailing list: ht
> Let's use "Charcoal Burner" for the worker and "Charcoal Kiln" for the
> building then - with the capital letters like that. English Speakers Like
> Their Title Case :P
The more I think about this, the more I realize I should have made a bug report.
Are we all agreed upon this suggestion? (Stil
Let's use "Charcoal Burner" for the worker and "Charcoal Kiln" for the building
then - with the capital letters like that. English Speakers Like Their Title
Case :P
--
https://code.launchpad.net/~widelands-dev/widelands/furnace/+merge/227810
Your team Widelands Developers is requested to review
"Charcoal burner" is fine for me. "Charcoal kiln" is more likely to be
confusing, but we will get used to it.
--
https://code.launchpad.net/~widelands-dev/widelands/furnace/+merge/227810
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/furna
Thanks! I think it might be beneficial to rename the worker from "Burner" to
"Charcoal Burner", if it doesn't confuse old players.
--
https://code.launchpad.net/~widelands-dev/widelands/furnace/+merge/227810
Your team Widelands Developers is requested to review the proposed merge of
lp:~wideland
I am sure there is a correct term, but if someone used it I probably wouldn't
recognise it! The Oxford English Dictionary states that one of the definitions
of "burner" is "a person...that burns".
On one of the sites linked about charcoal burning, there is the sentence:
"Chris Wall-Palmer lives
Shall we go with "Charcoal Kiln" for all 3 buildings then?
@ _aD: Is there a special name for the worker as well? At the moment, we're
simply using "Burner".
--
https://code.launchpad.net/~widelands-dev/widelands/furnace/+merge/227810
Your team Widelands Developers is requested to review the pro
Review: Needs Fixing
"Kiln" is the correct term, so "Charcoal Kiln" would be the most appropriate
phrase.
"Collier" is the term for a coal miner and "Colliery" is a coal mine. I believe
both of these words are primarily used in Britain. A furnace is where one would
burn charcoal to cook / smel
> Barbarians do not build houses. I understand that there is movement to unify
> names, but please also keep the in mind that the three tribes should be
> different and should have their own individuality.
We should have a "Charcoal Burner's Hut" then for consistency.
--
https://code.launchpad.n
Barbarians do not build houses. I understand that there is movement to unify
names, but please also keep the in mind that the three tribes should be
different and should have their own individuality.
aD, I added you as a reviewer since your a native speaker. Can you add anything
to the discussi
None of the proposed options really convinces me. I do not like "kiln" because
we already have a "lime kiln". As it stands, I prefer renaming all three to
"Charcoal Burner's House".
--
https://code.launchpad.net/~widelands-dev/widelands/furnace/+merge/227810
Your team Widelands Developers is req
> Some maps talk about not containing much coal and advise to build charcoal
> burners in their description. I do not know if such maps are shipped with
> Widelands though.
The plateau was the only map I found which mentioned "burner" in any way.
>The translation table in our wiki.
While I did
To unify the, we could all call them "Charcoal Burner's House". I did some
digging online and there doesn't seem to be an easy English term for the German
"Köhlerei" at all. You can have a pit or a stack, but what you see in-game is a
house:
What about "kiln"? http://www.charcoalburners.co.uk/c
Are you sure that "furnace" is the right term? From what I see, it seems to
describe what we call smelting works (that is at least what a quick look in
http://en.wikipedia.org/wiki/Charcoal reveals).
Furthermore, "charcoal furnace" (with quotation mark) has only 36,100 hit on
Google, while "char
The proposal to merge lp:~widelands-dev/widelands/furnace into lp:widelands has
been updated.
Description changed to:
As discussed on IRC earlier today, unify the charcoal burner/burner's house and
rename it to Charcoal Furnace.
Updated:
- tribes: images, names and conf
- campaigns: references
Hans Joachim Desserud has proposed merging lp:~widelands-dev/widelands/furnace
into lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/furnace/+merge/227810
As discussed on IRC earlier today, unify t
32 matches
Mail list logo
