Inputqueues again
@bunnybot merge force
--
https://code.launchpad.net/~widelands-dev/widelands/reed-compatibility/+merge/367935
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/reed-compatibility into lp:widelands.
_
Review: Approve
LGTM :)
But we need the server to be in place to test this better.
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1826744-lobby-commands/+merge/368285
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1826744-lobby-commands.
Review: Needs Fixing
I finally got around to doing the code review. This branch still has a lot of
room for streamlining the code and the performance.
Diff comments:
>
> === added file 'src/logic/map_objects/tribes/building_settings.cc'
> --- src/logic/map_objects/tribes/building_settings.cc 1
Thanks for the review! It should be OK. There were some merge conflicts, which
is why there might be some small additional stuff, but nothing serious.
I have pushed a commit to address your comments.
Diff comments:
>
> === modified file 'src/logic/editor_game_base.cc'
> --- src/logic/editor_ga
Done. Thanks for the review!
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/reed-compatibility/+merge/367935
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/reed-compatibility into lp:widelands.
This code is pretty old, so I'm sure we would have had bug reports for it in
the past if it was broken. It should be fine if iterating starts with the most
advanced working position, because then we won't put a master miner i a miner's
slot and end up stumped when we have to put a miner in a mas
I'll need to set aside a weekend for this, so it can take some time until I get
around to it.
--
https://code.launchpad.net/~widelands-dev/widelands/ferry/+merge/351880
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/ferry.
Looking mostly good, two comments in the diff.
I went through it commit by commit while ignoring the merges of trunk and
list-directories-in-cpp. I hope that is okay? I am a bit unsure about that
since there seem to be changes in the full diff that I can't find in the single
commits.
Diff comm
Sorry, I am having second thoughts about the goto-part. Actually, I am not only
unsure about the goto-replacement but over the whole code part independent of
your changes. :-/
If I understand it right, the code iterates over the possible jobs in the
production site. If there is a job the loaded
Now, how do we get progress here?
Will try to play this again on Cavisson
--
https://code.launchpad.net/~widelands-dev/widelands/ferry/+merge/351880
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/ferry.
___
Mailing l
10 matches
Mail list logo
