Shouldn't that be 'popup=true'?
--
https://code.launchpad.net/~widelands-dev/widelands/coroutine-error-collectors/+merge/362956
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/coroutine-error-collectors into lp:widelands.
__
Continuous integration builds have changed state:
Travis build 4454. State: passed. Details:
https://travis-ci.org/widelands/widelands/builds/491407941.
Appveyor build 4242. State: success. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_coroutine_
Toni Förster has proposed merging
lp:~widelands-dev/widelands/coroutine-error-collectors into lp:widelands.
Commit message:
add parameter to send_message() to avoid an error
Requested reviews:
Widelands Developers (widelands-dev)
For more details, see:
https://code.launchpad.net/~widelands-de
Continuous integration builds have changed state:
Travis build 4453. State: errored. Details:
https://travis-ci.org/widelands/widelands/builds/491252805.
Appveyor build 4241. State: success. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_bug_18100
Continuous integration builds have changed state:
Travis build 4452. State: passed. Details:
https://travis-ci.org/widelands/widelands/builds/491252462.
Appveyor build 4240. State: success. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_bug_memlea
Continuous integration builds have changed state:
Travis build 4450. State: passed. Details:
https://travis-ci.org/widelands/widelands/builds/491222019.
Appveyor build 4238. State: success. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_string_fix
Review: Needs Fixing
@hessenfarmer
I can't compile your changes, Travis isn't pleased as well.
/src/logic/field.h:261:1: error: static_assert failed "Field is not tightly
packed."
static_assert(sizeof(Field) == sizeof(void*) * 2 + 10, "Field is not tightly
packed.");
^
Continuous integration builds have changed state:
Travis build 4449. State: errored. Details:
https://travis-ci.org/widelands/widelands/builds/491209077.
Appveyor build 4237. State: success. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_campaigns
Continuous integration builds have changed state:
Travis build 4448. State: passed. Details:
https://travis-ci.org/widelands/widelands/builds/491208869.
Appveyor build 4236. State: success. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_scotty_the
Notabilis has proposed merging lp:~widelands-dev/widelands/bug-memleak-net-ui
into lp:widelands.
Commit message:
Fixing memory leak in network UI.
Requested reviews:
Widelands Developers (widelands-dev)
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/bug-memleak-ne
Review: Approve
Fix is okay, but as Klaus said. The related bugs don't fit. :-)
I'm going to remove them from the merge request.
--
https://code.launchpad.net/~widelands-dev/widelands/string-fixes/+merge/362944
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/
Review: Approve listen
Listend to the Sound at:
https://bazaar.launchpad.net/~widelands-dev/widelands/scotty_the_scout/view/head:/data/music/ingame_27.ogg
fine for me.
--
https://code.launchpad.net/~widelands-dev/widelands/scotty_the_scout/+merge/362943
Your team Widelands Developers is subscri
Uhm, I dont find any changes for #1421942, #1487887, #1530240, #1547909 ,
#1530398
Bu only soem pluar in the wincondition.
Can we get the relations correct?
The actual fix is ok :-)
--
https://code.launchpad.net/~widelands-dev/widelands/string-fixes/+merge/362944
Your team Widelands Developers
GunChleoc has proposed merging lp:~widelands-dev/widelands/string-fixes into
lp:widelands.
Commit message:
Fix pluralization error.
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #1421942 in widelands: "Unified term for "Black" and "Wasteland""
https://bugs.launc
I wrote some documentation, do you think it is understandable and sufficient?
--
https://code.launchpad.net/~widelands-dev/widelands/bug-better-syncstreams/+merge/361922
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-better-syncstreams.
___
Thanks for the reviews!
This is for Build 21, so let's not merge it yet.
--
https://code.launchpad.net/~widelands-dev/widelands/campaignselect_box/+merge/360901
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/campaignselect_box.
___
GunChleoc has proposed merging lp:~widelands-dev/widelands/scotty_the_scout
into lp:widelands.
Commit message:
New music track "Scotty the Scout" by Stuart Marshall
Requested reviews:
Widelands Developers (widelands-dev)
For more details, see:
https://code.launchpad.net/~widelands-dev/widelan
The proposal to merge lp:~widelands-dev/widelands/bug-1805325-joining-lan-games
into lp:widelands has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/bug-1805325-joining-lan-games/+merge/359789
--
Your team Widelands De
I have done some similar testing. I'd like to see a few changes:
1. WLApplication:cleanup_replays() does not clean up old wse files
2. There are no instructions in the Python script.
I'd like to at least see a usage hint when it's called without parameters.
--
https://code.launchpad.net/~widel
I tested(?) it by enforcing a desync (modifying player.cc and using std::rand()
as ID for new economies, then changing economy targets ingame). The new *.wse
files were created and could be parsed by the python script. No idea what else
can be tested.
--
https://code.launchpad.net/~widelands-de
This fixes a crash, so let's have it.
Clang install failure on Travis
@bunnybot merge force
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1805325-joining-lan-games/+merge/359789
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1805325-joining-l
21 matches
Mail list logo
