[Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/inquiry_spam into lp:widelands-website

2019-01-19 Thread kaputtnik
kaputtnik has proposed merging lp:~widelands-dev/widelands-website/inquiry_spam into lp:widelands-website. Commit message: Add a simple spam filter to legal_notice checking for ALLOWED_INQUIRY_HOSTS Requested reviews: Widelands Developers (widelands-dev) Related bugs: Bug #1799375 in Widelan

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/workerwarehotspots into lp:widelands

2019-01-19 Thread kaputtnik
I understand your point and i wanted to have also some bugs fixed. The problem: Each code change, even it looks very small and secure, has the potential to break some other thing. > In my opinion feature freaze means bugfixing mode. Yes, outstanding bugs targeted for build20 and new critical bu

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/robust-file-saving into lp:widelands

2019-01-19 Thread Klaus Halfmann
Review: Approve reaprove I think should get this in now, I dont think it will break anything. @bunnybot merge -- https://code.launchpad.net/~widelands-dev/widelands/robust-file-saving/+merge/358718 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/robust-file-sa

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/workerwarehotspots into lp:widelands

2019-01-19 Thread hessenfarmer
@ Kaputtnik: In my opinion feature freaze means bugfixing mode. I agree that this bug isn't targeted for b20 due to not beeing important enough. But this should not hinder us fixing a bug if a solution is there. like we did with the resis and frisian bushes. So for me we could and should merge t

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/workerwarehotspots into lp:widelands

2019-01-19 Thread kaputtnik
The bug is targeted to build 21 and we are in first feature freeze. Please do not merge before we have build20 released :) If possible, everyone should focus his work now on the desyncs, imho. -- https://code.launchpad.net/~widelands-dev/widelands/workerwarehotspots/+merge/359915 Your team Widel