Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug1790456_game_summary into lp:widelands

2018-10-01 Thread hessenfarmer
BTW time isn't completly superfluous as it shows the player end time - normally this is the total game time for the winner and last opponent but it is different for a player who lost early (i.e. lost it's last headquarters) >From my imagination this might be interesting in multiplayer games, at

[Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/cookies into lp:widelands-website

2018-10-01 Thread kaputtnik
kaputtnik has proposed merging lp:~widelands-dev/widelands-website/cookies into lp:widelands-website. Commit message: Use a session based csrf cookie; Fixed showing deleted username when quoting a post Requested reviews: Widelands Developers (widelands-dev) Related bugs: Bug #1780536 in Wid

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/frisian_balancing_worldsavior_201809 into lp:widelands

2018-10-01 Thread bunnybot
Continuous integration builds have changed state: Travis build 4084. State: passed. Details: https://travis-ci.org/widelands/widelands/builds/435511178. Appveyor build 3880. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_frisian_ba

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/frisian_balancing_worldsavior_201809 into lp:widelands

2018-10-01 Thread weedfreak
Agree, lowering any experience levels is a bad move, in my mind anything below 20 for any worker in any tribe is pointless. It makes the the whole progression system pointless. I have tried Frisians with many values and have settled with numbers in the 30's as being best. I also disagee with an

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug1790456_game_summary into lp:widelands

2018-10-01 Thread hessenfarmer
As this bug is targeted for b20, the question is what to do for the moment being? I would vote for having this in the state as for b19 (that's why I didn't any further changes). And do the changes you proposed for b21. Otherwise we would have another string to translate and other implications -

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/frisian_balancing_worldsavior_201809 into lp:widelands

2018-10-01 Thread Benedikt Straub
Review: Needs Fixing I´m fine with the changes to training camp and tavern. Having the aqua farm consume just 1 water is illogical, because the water is needed to fill a pond. It should be at least 2 water per cycle. I am *very* unhappy about the experience changes, since large experience deman

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/per-level-soldier-anims into lp:widelands

2018-10-01 Thread GunChleoc
Yes, this is definitely for Build 21. We can already start the review process though. -- https://code.launchpad.net/~widelands-dev/widelands/per-level-soldier-anims/+merge/354929 Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/per-level-sol

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/frisian_balancing_worldsavior_201809 into lp:widelands

2018-10-01 Thread GunChleoc
GunChleoc has proposed merging lp:~widelands-dev/widelands/frisian_balancing_worldsavior_201809 into lp:widelands. Commit message: Various balancing changes for Frisian production. Requested reviews: Widelands Developers (widelands-dev) For more details, see: https://code.launchpad.net/~wide

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug1790456_game_summary into lp:widelands

2018-10-01 Thread GunChleoc
Actually, the "time" column is completely superfluous, because it's the same for all players - we're showing the "Elapsed time" on the bottom, that is enough. I think we should just get rid of it, or will it with the score instead. Then we can fill the "player info" area with more detailed info