No worries - thanks for all the reviews you're doing!
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1699852-compiler-warning/+merge/355884
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/bug-1699852-compiler-warning into lp:wide
Another possible solution might be to do 2 things:
1. Set modal to nullptr only after calling disconnect
2. Showing the message only if model != nullptr and logging to console otherwise
So,
d->modal = nullptr;
WLApplication::emergency_save(game);
d
Thanks for fixing this one, syntax and usage of templates in C++ still give me
a headache.
I will try to review it,but I am running out of time for this weekend.
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1699852-compiler-warning/+merge/355884
Your team Widelands Developers is re
GunChleoc has proposed merging
lp:~widelands-dev/widelands/bug-1699852-compiler-warning into lp:widelands.
Commit message:
Fix [-Wundefined-func-template] compiler warnings.
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #1699852 in widelands: "Instantiation warnin
In my case the root cause was a savegame incompatibilty.
void GameClient::disconnect in network/gameclient.cc creates the messagebox as:
UI::WLMessageBox mmb(d->modal,
d is a GameClientImpl* and modal is explicily set as nullpointer in the CTor.
modal is always set to the currently show win
* Source Package: widelands
* Version: 1:19-ppa0-bzr8862-201809300602~ubuntu14.04.1
* Architecture: i386
* Archive: ~widelands-dev/ubuntu/widelands-daily
* Component: main
* State: Failed to build
* Duration: 4 minutes
* Build Log:
https://launchpad.net/~widelands-dev/+archive/ubuntu/wid
* Source Package: widelands
* Version: 1:19-ppa0-bzr8862-201809300602~ubuntu14.04.1
* Architecture: amd64
* Archive: ~widelands-dev/ubuntu/widelands-daily
* Component: main
* State: Failed to build
* Duration: 3 minutes
* Build Log:
https://launchpad.net/~widelands-dev/+archive/ubuntu/wi
Continuous integration builds have changed state:
Travis build 4077. State: passed. Details:
https://travis-ci.org/widelands/widelands/builds/435064780.
Appveyor build 3873. State: success. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_compiler_w
Continuous integration builds have changed state:
Travis build 4076. State: passed. Details:
https://travis-ci.org/widelands/widelands/builds/435018665.
Appveyor build 3872. State: success. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_bug_179433
GunChleoc has proposed merging
lp:~widelands-dev/widelands/compiler_warnings_200809 into lp:widelands.
Commit message:
Fixed most compiler warnings for clang.
Requested reviews:
Widelands Developers (widelands-dev)
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/com
No, we can't center to a global parent, because the direct parent is already
nullptr.
I am wondering whether this fix doesn't just mask the real bug - it would be
interesting to track down why that particular window has no parent. There's
something wrong with the control flow there.
--
https:/
Klaus Halfmann has proposed merging
lp:~widelands-dev/widelands/bug_1794339_center_wo_parent into lp:widelands.
Commit message:
Avoid null access in Window::center_to_parent()
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #1794339 in widelands: "segfault joining g
Review: Approve
Great, thanks!
Can go in once it's been tested :)
--
https://code.launchpad.net/~widelands-dev/widelands/fri-01-02-improvements/+merge/355843
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/fri-01-02-improvements.
_
The proposal to merge lp:~widelands-dev/widelands/detect_revision_update into
lp:widelands has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/detect_revision_update/+merge/355590
--
Your team Widelands Developers is su
Continuous integration builds have changed state:
Travis build 4071. State: passed. Details:
https://travis-ci.org/widelands/widelands/builds/434910227.
Appveyor build 3867. State: success. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_bug_175985
I have tested both git and bzr. Linux is fine, so is git on MSys2. I could not
it to work with bazaar on MSys2, but that's because the bzr pypi package is
buggy, and it's accordingly already broken in trunk.
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/detect_revision_
OK, implemented your diff comments and uploaded the string changes to your
localization branch
--
https://code.launchpad.net/~widelands-dev/widelands/fri-01-02-improvements/+merge/355843
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/fri-0
Since I touched some core code for MapObjects in general, this needs careful
testing to make sure I didn´t break anything (although it´s unlikely).
Postponing this until b20 is out would probably be sensible.
--
https://code.launchpad.net/~widelands-dev/widelands/per-level-soldier-anims/+merge/3
The proposal to merge lp:~widelands-dev/widelands/frisian_balancing_2 into
lp:widelands has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/frisian_balancing_2/+merge/355358
--
Your team Widelands Developers is subscrib
19 matches
Mail list logo
