Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug1792297_worker_encyclopedia into lp:widelands

2018-09-23 Thread GunChleoc
I have pushed a string fix. I think the code for the collection of buildings needs fixing though. It will break as soon as somebody creates a tribe with more than 3 worker levels. I recommend the following: 1. Collect the buildings the worker works at directly in a table 2. Create a second tabl

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/fix-travis into lp:widelands

2018-09-23 Thread hessenfarmer
Imho nothing should be done in trunk directly. As this fix would not have been necessary in this case -- https://code.launchpad.net/~widelands-dev/widelands/fix-travis/+merge/355525 Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/fix-travi

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/fix-travis into lp:widelands

2018-09-23 Thread noreply
The proposal to merge lp:~widelands-dev/widelands/fix-travis into lp:widelands has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~widelands-dev/widelands/fix-travis/+merge/355525 -- Your team Widelands Developers is requested to review the pr

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/fix-travis into lp:widelands

2018-09-23 Thread bunnybot
Continuous integration builds have changed state: Travis build 4018. State: passed. Details: https://travis-ci.org/widelands/widelands/builds/432238408. Appveyor build 3815. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_fix_travis

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/fix-travis into lp:widelands

2018-09-23 Thread kaputtnik
:-) Such minor changes could be done in trunk immediately, imho. @bunnybot merge force -- https://code.launchpad.net/~widelands-dev/widelands/fix-travis/+merge/355525 Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/fix-travis into lp:widela

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/fix-travis into lp:widelands

2018-09-23 Thread hessenfarmer
hessenfarmer has proposed merging lp:~widelands-dev/widelands/fix-travis into lp:widelands. Commit message: Deletion of 3 erroneously introduced trailing whitespaces to fix travis codecheck. Requested reviews: Widelands Developers (widelands-dev) For more details, see: https://code.launchpa

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1480927-building-texts into lp:widelands

2018-09-23 Thread bunnybot
Continuous integration builds have changed state: Travis build 4017. State: failed. Details: https://travis-ci.org/widelands/widelands/builds/432126021. Appveyor build 3814. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_bug_148092

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1480927-building-texts into lp:widelands

2018-09-23 Thread Klaus Halfmann
Review: Approve compile, review, testplay Now ok for me, will still do some testplaye, feel free to merge. -- https://code.launchpad.net/~widelands-dev/widelands/bug-1480927-building-texts/+merge/353728 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-148092

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/immovable-grow-owner into lp:widelands

2018-09-23 Thread Benedikt Straub
Travis fails because of codecheck errors that are already in trunk -- https://code.launchpad.net/~widelands-dev/widelands/immovable-grow-owner/+merge/355518 Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/immovable-grow-owner into lp:widelan