Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/string-fixes into lp:widelands

2018-09-12 Thread GunChleoc
Problem with the new sphinx version, unrelated to this branch. @bunnybot merge force -- https://code.launchpad.net/~widelands-dev/widelands/string-fixes/+merge/354792 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/string-fixes. ___

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/fix-sphinx into lp:widelands

2018-09-12 Thread GunChleoc
@bunnybot merge force -- https://code.launchpad.net/~widelands-dev/widelands/fix-sphinx/+merge/354827 Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/fix-sphinx into lp:widelands. ___ Mailing list

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1791891-key-modifier-inputqueue into lp:widelands

2018-09-12 Thread GunChleoc
Tested. Now, how will the user find out about this feature? There should be additional info in the tooltip and/or in the helptexts explaining the keyboard shortcuts. -- https://code.launchpad.net/~widelands-dev/widelands/bug-1791891-key-modifier-inputqueue/+merge/354732 Your team Widelands Devel

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/fix-sphinx into lp:widelands

2018-09-12 Thread GunChleoc
GunChleoc has proposed merging lp:~widelands-dev/widelands/fix-sphinx into lp:widelands. Commit message: Remove sphinx from debug builds on Travis. Requested reviews: Widelands Developers (widelands-dev) Related bugs: Bug #1792291 in widelands: "Sphinx is broken on Travis" https://bugs.lau

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/string-fixes into lp:widelands

2018-09-12 Thread bunnybot
Refusing to merge, since Travis is not green. Use @bunnybot merge force for merging anyways. Travis build 3955. State: failed. Details: https://travis-ci.org/widelands/widelands/builds/427787004. -- https://code.launchpad.net/~widelands-dev/widelands/string-fixes/+merge/354792 Your team Widelan

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/string-fixes into lp:widelands

2018-09-12 Thread bunnybot
Continuous integration builds have changed state: Travis build 3955. State: failed. Details: https://travis-ci.org/widelands/widelands/builds/427787004. Appveyor build 3753. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_string_fix

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/string-fixes into lp:widelands

2018-09-12 Thread GunChleoc
@bunnybot merge -- https://code.launchpad.net/~widelands-dev/widelands/string-fixes/+merge/354792 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/string-fixes. ___ Mailing list: https://launchpad.net/~widelands-dev Po

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1434875-net-client-disconnect into lp:widelands

2018-09-12 Thread Notabilis
Thanks for the bug report, the local fix and the review. Your remarks are hopefully all fixed now. Do we need a translator comment for both occurrences of "Replace with %s" or is one comment enough when it is the same string? -- https://code.launchpad.net/~widelands-dev/widelands/bug-1434875-net

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1772168-unused-key-in-luatable into lp:widelands

2018-09-12 Thread bunnybot
Continuous integration builds have changed state: Travis build 3949. State: passed. Details: https://travis-ci.org/widelands/widelands/builds/427562201. Appveyor build 3747. State: failed. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_bug_1772168

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1751440-smugglers-desync-single-coroutine into lp:widelands

2018-09-12 Thread bunnybot
Continuous integration builds have changed state: Travis build 3948. State: errored. Details: https://travis-ci.org/widelands/widelands/builds/427560056. Appveyor build 3746. State: failed. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_bug_175144

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/string-fixes into lp:widelands

2018-09-12 Thread hessenfarmer
Review: Approve changes look good for me: -- https://code.launchpad.net/~widelands-dev/widelands/string-fixes/+merge/354792 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/string-fixes. ___ Mailing list: https://la

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1669103-no-automatic-dismantlesitewindow into lp:widelands

2018-09-12 Thread noreply
The proposal to merge lp:~widelands-dev/widelands/bug-1669103-no-automatic-dismantlesitewindow into lp:widelands has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~widelands-dev/widelands/bug-1669103-no-automatic-dismantlesitewindow/+merge/35

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/rework-resource-indicators into lp:widelands

2018-09-12 Thread GunChleoc
Review: Approve Yes, we have a winner :D @bunnybot merge > I´ve lost count the how-many-th version this is ;) Me too... I find code easier to review *lol* -- https://code.launchpad.net/~widelands-dev/widelands/rework-resource-indicators/+merge/353996 Your team Widelands Developers is subscrib

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/string-fixes into lp:widelands

2018-09-12 Thread GunChleoc
GunChleoc has proposed merging lp:~widelands-dev/widelands/string-fixes into lp:widelands. Commit message: 2 string fixes Requested reviews: Widelands Developers (widelands-dev) Related bugs: Bug #1421942 in widelands: "Unified term for "Black" and "Wasteland"" https://bugs.launchpad.net/w

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1434875-net-client-disconnect into lp:widelands

2018-09-12 Thread bunnybot
Continuous integration builds have changed state: Travis build 3945. State: passed. Details: https://travis-ci.org/widelands/widelands/builds/427533795. Appveyor build 3743. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_bug_143487

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1766957-sinking-ship-animation into lp:widelands

2018-09-12 Thread noreply
The proposal to merge lp:~widelands-dev/widelands/bug-1766957-sinking-ship-animation into lp:widelands has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~widelands-dev/widelands/bug-1766957-sinking-ship-animation/+merge/353746 -- Your team W

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/ferry into lp:widelands

2018-09-12 Thread Benedikt Straub
The proposal to merge lp:~widelands-dev/widelands/ferry into lp:widelands has been updated. Status: Needs review => Work in progress For more details, see: https://code.launchpad.net/~widelands-dev/widelands/ferry/+merge/351880 -- Your team Widelands Developers is requested to review the pr

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/rework-resource-indicators into lp:widelands

2018-09-12 Thread Benedikt Straub
I´ve lost count the how-many-th version this is ;) I find only one strip of cloth hard to see, unless it´s very broad. How about these new crossed silk strips? -- https://code.launchpad.net/~widelands-dev/widelands/rework-resource-indicators/+merge/353996 Your team Widelands Developers is subscri

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1766957-sinking-ship-animation into lp:widelands

2018-09-12 Thread GunChleoc
@bunnybot merge -- https://code.launchpad.net/~widelands-dev/widelands/bug-1766957-sinking-ship-animation/+merge/353746 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1766957-sinking-ship-animation. ___ Mailing l

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1791891-key-modifier-inputqueue into lp:widelands

2018-09-12 Thread bunnybot
Continuous integration builds have changed state: Travis build 3943. State: failed. Details: https://travis-ci.org/widelands/widelands/builds/427411087. Appveyor build 3741. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_bug_179189

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1791891-key-modifier-inputqueue into lp:widelands

2018-09-12 Thread Benedikt Straub
Review: Approve code Code LGTM, not tested. Thanks! -- https://code.launchpad.net/~widelands-dev/widelands/bug-1791891-key-modifier-inputqueue/+merge/354732 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1791891-key-modifier-inputqueue. __

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/rework-resource-indicators into lp:widelands

2018-09-12 Thread GunChleoc
Empire is good now :) Atlantean "none" still signals to me that there is something important there - it's visually too busy. Try just 1 strip of cloth in the middle and remove the 3rd pole? -- https://code.launchpad.net/~widelands-dev/widelands/rework-resource-indicators/+merge/353996 Your team