[Widelands-dev] [Merge] lp:~widelands-dev/widelands/mines-worldsavior into lp:widelands

2018-07-24 Thread bunnybot
Continuous integration builds have changed state: Travis build 3721. State: passed. Details: https://travis-ci.org/widelands/widelands/builds/407778348. Appveyor build 3521. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_mines_worl

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/no-hardcoded-resources into lp:widelands

2018-07-24 Thread bunnybot
Continuous integration builds have changed state: Travis build 3720. State: passed. Details: https://travis-ci.org/widelands/widelands/builds/407776857. Appveyor build 3520. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_no_hardcod

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/no-hardcoded-resources into lp:widelands

2018-07-24 Thread Benedikt Straub
Benedikt Straub has proposed merging lp:~widelands-dev/widelands/no-hardcoded-resources into lp:widelands. Commit message: Removed hardcoding for resources Requested reviews: Widelands Developers (widelands-dev) Related bugs: Bug #1713706 in widelands: "Remove hard-coding for resource types

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/fri-01-portspace into lp:widelands

2018-07-24 Thread bunnybot
Continuous integration builds have changed state: Travis build 3719. State: passed. Details: https://travis-ci.org/widelands/widelands/builds/407640491. Appveyor build 3519. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_fri_01_por

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/mines-worldsavior into lp:widelands

2018-07-24 Thread hessenfarmer
found an error which prevented playtesting will fix the errors and upload within an hour so please do not upload anything until then. Diff comments: > > === modified file > 'data/tribes/buildings/productionsites/frisians/rockmine_deep/init.lua' > --- data/tribes/buildings/productionsites/frisi

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/mines-worldsavior into lp:widelands

2018-07-24 Thread hessenfarmer
I agree to Nordfrieses last comment. Just ignore my commet about worker experience didn't see that it is the upgraded building. We should document the new philosophy of the mines preferably in the RST section: - now one ressource on the map delivers exactly one ware - the probability is now cal

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/fri-01-portspace into lp:widelands

2018-07-24 Thread Benedikt Straub
Benedikt Straub has proposed merging lp:~widelands-dev/widelands/fri-01-portspace into lp:widelands. Commit message: Adds another port space to scenario fri01 to fix difficulties with finding and reaching the port space Requested reviews: MP (pagel-d) Related bugs: Bug #1783115 in widelands

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/mines-worldsavior into lp:widelands

2018-07-24 Thread Benedikt Straub
Found another issue: For the buildings where the penalty for missing wares has been removed, the program order is now: "return=skipped unless economy needs ", "consume=", "animate=working ", "sleep=", "produce=" The last two lines should be switched here for all those buildings. It´ll lo

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/mines-worldsavior into lp:widelands

2018-07-24 Thread bunnybot
Continuous integration builds have changed state: Travis build 3718. State: failed. Details: https://travis-ci.org/widelands/widelands/builds/407539420. Appveyor build 3518. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_mines_worl

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/mines-worldsavior into lp:widelands

2018-07-24 Thread hessenfarmer
Agree to most of Nordfrieses Comments stats are looking much better now in the Excel. will upload them to the bug ASAP Diff comments: > > === modified file > 'data/tribes/buildings/productionsites/atlanteans/coalmine/init.lua' > --- data/tribes/buildings/productionsites/atlanteans/coalmine/in

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/mines-worldsavior into lp:widelands

2018-07-24 Thread Benedikt Straub
Review: Needs Fixing review Reviewed the code, added a lot of small comments for code style. Feel free to ignore. Also found a typo in the frisian deep gold mine and a possible bug in the design of all mines, please fix. Is it really intended that the frisian deep gold and iron mines produce go

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/mines-worldsavior into lp:widelands

2018-07-24 Thread GunChleoc
The proposal to merge lp:~widelands-dev/widelands/mines-worldsavior into lp:widelands has been updated. Commit message changed to: Diverse balancing tweaks for productionsites - Honey Bread Bakery now only ignores economy requirements when producing Honeybread and the workers need experience.

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/mines-worldsavior into lp:widelands

2018-07-24 Thread GunChleoc
GunChleoc has proposed merging lp:~widelands-dev/widelands/mines-worldsavior into lp:widelands. Commit message: Diverse balancing tweaks for productionsites - Honey Bread Bakery now only ignores economy requirements when producing Honeybread and the workers need experience. Same goes for Mead B