[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1406298-campvis-file into lp:widelands

2018-07-07 Thread bunnybot
Continuous integration builds have changed state: Travis build 3638. State: errored. Details: https://travis-ci.org/widelands/widelands/builds/401293949. Appveyor build 3437. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_bug_14062

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1769344-sp-thinks-too-much into lp:widelands

2018-07-07 Thread noreply
The proposal to merge lp:~widelands-dev/widelands/bug-1769344-sp-thinks-too-much into lp:widelands has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~widelands-dev/widelands/bug-1769344-sp-thinks-too-much/+merge/346911 -- Your team Widelands

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1769344-sp-thinks-too-much into lp:widelands

2018-07-07 Thread GunChleoc
Transient failure on Travis @bunnybot merge force -- https://code.launchpad.net/~widelands-dev/widelands/bug-1769344-sp-thinks-too-much/+merge/346911 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1769344-sp-thinks-too-much. __

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1724145-corrupt-zip-when-saving into lp:widelands

2018-07-07 Thread bunnybot
Continuous integration builds have changed state: Travis build 3635. State: passed. Details: https://travis-ci.org/widelands/widelands/builds/401193955. Appveyor build 3434. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_bug_172414

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1769344-sp-thinks-too-much into lp:widelands

2018-07-07 Thread bunnybot
Refusing to merge, since Travis is not green. Use @bunnybot merge force for merging anyways. Travis build 3627. State: errored. Details: https://travis-ci.org/widelands/widelands/builds/400787180. -- https://code.launchpad.net/~widelands-dev/widelands/bug-1769344-sp-thinks-too-much/+merge/34691

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/remove_nocom_logs_campaign_data into lp:widelands

2018-07-07 Thread noreply
The proposal to merge lp:~widelands-dev/widelands/remove_nocom_logs_campaign_data into lp:widelands has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~widelands-dev/widelands/remove_nocom_logs_campaign_data/+merge/349088 -- Your team Widelan

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/remove_nocom_logs_campaign_data into lp:widelands

2018-07-07 Thread bunnybot
Continuous integration builds have changed state: Travis build 3634. State: passed. Details: https://travis-ci.org/widelands/widelands/builds/401193238. Appveyor build 3433. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_remove_noc

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1769344-sp-thinks-too-much into lp:widelands

2018-07-07 Thread GunChleoc
Thanks for the review and testing. Yes it does take some getting used to - let's see how the users react. It's going to change eventually anyway, when I get around to implementing the dropdown menus - probably for Build 21. I didn't use a fallthrough because I was to lazy to bother with the macr

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/remove_nocom_logs_campaign_data into lp:widelands

2018-07-07 Thread GunChleoc
Thanks for the review :) @bunnybot merge -- https://code.launchpad.net/~widelands-dev/widelands/remove_nocom_logs_campaign_data/+merge/349088 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/remove_nocom_logs_campaign_data. _

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/remove_nocom_logs_campaign_data into lp:widelands

2018-07-07 Thread Benedikt Straub
Review: Approve review, test Compiled and tested, works as it should. Code changes look good to me. -- https://code.launchpad.net/~widelands-dev/widelands/remove_nocom_logs_campaign_data/+merge/349088 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/remove_nocom

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1769344-sp-thinks-too-much into lp:widelands

2018-07-07 Thread Notabilis
Review: Approve Seems to be working as intended now, thanks. Code is looking good, too. Reading the tribes from the map file will need some getting used to but I think it is the correct approach. At first, it is a bit strange that the tribe is "reset" when changing the map but AI difficulty and

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/remove_nocom_logs_campaign_data into lp:widelands

2018-07-07 Thread GunChleoc
GunChleoc has proposed merging lp:~widelands-dev/widelands/remove_nocom_logs_campaign_data into lp:widelands. Commit message: Removed logs in campaign data that are no longer needed. Made some strings const. Requested reviews: Widelands Developers (widelands-dev) For more details, see: https

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1724145-corrupt-zip-when-saving into lp:widelands

2018-07-07 Thread GunChleoc
GunChleoc has proposed merging lp:~widelands-dev/widelands/bug-1724145-corrupt-zip-when-saving into lp:widelands. Commit message: Do not save LuaEconomy objects in Lua scrips for use later - Due to economy merging, the economy object can become unavailable and cause crashes. - Fixed Lua script

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/road_promotions into lp:widelands

2018-07-07 Thread ypopezios
Description fixed. -- https://code.launchpad.net/~widelands-dev/widelands/road_promotions/+merge/344182 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/road_promotions. ___ Mailing list: https://launchpad.net/~widelan

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/road_promotions into lp:widelands

2018-07-07 Thread ypopezios
The proposal to merge lp:~widelands-dev/widelands/road_promotions into lp:widelands has been updated. Description changed to: This is supposed to improve how roads get promoted and demoted under all possible scenarios, without surprises or other negative side-effects (basically without oscilla

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/road_promotions into lp:widelands

2018-07-07 Thread noreply
The proposal to merge lp:~widelands-dev/widelands/road_promotions into lp:widelands has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~widelands-dev/widelands/road_promotions/+merge/344182 -- Your team Widelands Developers is subscribed to br

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/road_promotions into lp:widelands

2018-07-07 Thread GunChleoc
@bunnybot merge -- https://code.launchpad.net/~widelands-dev/widelands/road_promotions/+merge/344182 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/road_promotions. ___ Mailing list: https://launchpad.net/~widelands-

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/road_promotions into lp:widelands

2018-07-07 Thread GunChleoc
The proposal to merge lp:~widelands-dev/widelands/road_promotions into lp:widelands has been updated. Commit message changed to: Improved algorithm for promotion and demotion of roads For more details, see: https://code.launchpad.net/~widelands-dev/widelands/road_promotions/+merge/344182 -- Yo

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/road_promotions into lp:widelands

2018-07-07 Thread Klaus Halfmann
ypopezios: I will test this now, but please change the description what this is about. -- https://code.launchpad.net/~widelands-dev/widelands/road_promotions/+merge/344182 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/road_promotions. ___

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1406298-campvis-file into lp:widelands

2018-07-07 Thread Klaus Halfmann
Still no Appveyor build here? -- https://code.launchpad.net/~widelands-dev/widelands/bug-1406298-campvis-file/+merge/346915 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1406298-campvis-file. ___ Mailing list: h