Continuous integration builds have changed state:
Travis build 3402. State: passed. Details:
https://travis-ci.org/widelands/widelands/builds/369856941.
Appveyor build 3208. State: success. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_Economy_tu
Continuous integration builds have changed state:
Travis build 3401. State: failed. Details:
https://travis-ci.org/widelands/widelands/builds/369821982.
Appveyor build 3207. State: success. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_net_online
branch is playtested
however grammar and language should be checked
--
https://code.launchpad.net/~widelands-dev/widelands/Economy_tutorial_fix/+merge/343770
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/Economy_tutorial_fix into lp:widela
hessenfarmer has proposed merging
lp:~widelands-dev/widelands/Economy_tutorial_fix into lp:widelands.
Commit message:
fixes Bug #1624001
explains the new enhanced encyclopedia within the economy tutorial
Requested reviews:
Widelands Developers (widelands-dev)
For more details, see:
https://co
Notabilis has proposed merging
lp:~widelands-dev/widelands/net-online-game-status into lp:widelands with
lp:~widelands-dev/widelands/net-remove-tell_ip as a prerequisite.
Commit message:
Dealing with more expressive information about game state from the metaserver.
Requested reviews:
Wideland
Continuous integration builds have changed state:
Travis build 3397. State: passed. Details:
https://travis-ci.org/widelands/widelands/builds/369740569.
Appveyor build 3203. State: success. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_bug_174308
It looks indeed as it might have been a game or chat bot. But I don't know
whether there have been any at some time. I am not aware of any that are
currently active.
Thanks for the review and for fixing the one nit. I replaced the numeric
constants with const variables, an enum wasn't possible
OK, I added the honey to the bread
--
https://code.launchpad.net/~widelands-dev/widelands/frisians-fix/+merge/343755
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/frisians-fix.
___
Mailing list: https://launchpad.ne
Continuous integration builds have changed state:
Travis build 3396. State: failed. Details:
https://travis-ci.org/widelands/widelands/builds/369727261.
Appveyor build 3202. State: failed. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_background_
please do a quick check of the lore text for the Honeybread bakery imo the
honey is missing in the text would sound better ... that koneybread is sweeter
--
https://code.launchpad.net/~widelands-dev/widelands/frisians-fix/+merge/343755
Your team Widelands Developers is subscribed to branch
lp:~w
Klaus Halfmann has proposed merging
lp:~widelands-dev/widelands/bug-1743086-sdl-sound-bug-workaround into
lp:widelands.
Commit message:
Workaround for Bug 1743086, completly disable sound in this case.
Test this on "Linux Budgie 4.13.0-38-generic #43-Ubuntu SMP Wed Mar 14 15:20:44
UTC 2018 x86
Sorry, should have mentioned it: This branch is not compatible with the
currently running metaserver. So its "fine" that it looks strange.
Feel free to commit your change. I will look at your suggestions later on.
--
https://code.launchpad.net/~widelands-dev/widelands/net-user-type/+merge/343754
@Klaus: Glad it's working better now. I have opened a bug to update Travis with
the new version too: https://bugs.launchpad.net/widelands/+bug/1766069
--
https://code.launchpad.net/~widelands-dev/widelands/net-user-type/+merge/343754
Your team Widelands Developers is subscribed to branch
lp:~wid
Review: Approve
Code LGTM :)
Since GAME_OPEN and GAME_CONNECT aren't called that often, I think a bit of
overhead is fine. I like he flexibility.
--
https://code.launchpad.net/~widelands-dev/widelands/net-remove-tell_ip/+merge/343753
Your team Widelands Developers is subscribed to branch
lp:~w
Review: Needs Fixing compile, testplay
I checekd the Multiplayer lobby and it looks garbled now,
will you need a screenshot?
I did a small improvemenet in gamechatpanel.cc, not sure if I should commit it?
--
https://code.launchpad.net/~widelands-dev/widelands/net-user-type/+merge/343754
Your tea
Review: Approve
Code LGTM, not tested
--
https://code.launchpad.net/~widelands-dev/widelands/frisians-fix/+merge/343755
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/frisians-fix.
___
Mailing list: https://launchpa
16 matches
Mail list logo
