Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/background_images into lp:widelands

2018-04-18 Thread GunChleoc
I have committed my graphics source files to the media repository now: https://bazaar.launchpad.net/~widelands-media-dev/widelands-media/widelands-media/files/head:/graphics/user_interface/ui_fsmenu/ -- https://code.launchpad.net/~widelands-dev/widelands/background_images/+merge/337629 Your team

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/django1_11 into lp:widelands-website

2018-04-18 Thread kaputtnik
Review: Needs Fixing Regarding the screenshots: They old ones aren't physical there. I have tested it by adding two categories and uploaded two images to each categorie. The online_users_middleware does not work as i expected... Hitting 'log out' does not remove the user name from the list. Bu

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/ai_new_wai_files_18042018 into lp:widelands

2018-04-18 Thread noreply
The proposal to merge lp:~widelands-dev/widelands/ai_new_wai_files_18042018 into lp:widelands has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~widelands-dev/widelands/ai_new_wai_files_18042018/+merge/343492 -- Your team Widelands Developers

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/ai_new_wai_files_18042018 into lp:widelands

2018-04-18 Thread bunnybot
Continuous integration builds have changed state: Travis build 3390. State: passed. Details: https://travis-ci.org/widelands/widelands/builds/368083977. Appveyor build 3196. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_ai_new_wai

[Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/django1_11 into lp:widelands-website

2018-04-18 Thread kaputtnik
The proposal to merge lp:~widelands-dev/widelands-website/django1_11 into lp:widelands-website has been updated. Description changed to: Major update of the website code to Django 1.11.12. I have gone through all release notes form Django 1.8 until Django 1.11. - Added migrations for wlscreens

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/django1_11 into lp:widelands-website

2018-04-18 Thread kaputtnik
Got the callback function to work. Will apply the latest change to the alpha site, so this can also be tested in production. Have to shut down and restart the alpha site again... -- https://code.launchpad.net/~widelands-dev/widelands-website/django1_11/+merge/343065 Your team Widelands Develop

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/1733279-ingame-clock into lp:widelands

2018-04-18 Thread bunnybot
Continuous integration builds have changed state: Travis build 3389. State: passed. Details: https://travis-ci.org/widelands/widelands/builds/368035845. Appveyor build 3195. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_1733279_in

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/django1_11 into lp:widelands-website

2018-04-18 Thread GunChleoc
> Can you give an example for real world name containing an apostrophe? John O'Neill, Iain Mac a' Ghobhainn +1 for Unicode names, that would be really cool :) I don't think that we need to resolve the username issue in this branch though. I'll try to get some testing in this week. -- https://c

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/ai_new_wai_files_18042018 into lp:widelands

2018-04-18 Thread GunChleoc
Review: Approve Thanks! :) @bunnybot merge -- https://code.launchpad.net/~widelands-dev/widelands/ai_new_wai_files_18042018/+merge/343492 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/ai_new_wai_files_18042018. __

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/django1_11 into lp:widelands-website

2018-04-18 Thread kaputtnik
Allowing ' needs implementing an own username validator. Can you give an example for real world name containing an apostrophe? What we should consider is to allow unicode characters in usernames, so french, or polish names can be used.See https://docs.djangoproject.com/en/1.11/ref/contrib/auth/

[Widelands-dev] Feature Freeze planning

2018-04-18 Thread Fòram na Gàidhlig
Dear devs, I'd like us to focus on working towards feature freeze now. I have put up all my feature branches that I'd like to have in Build 20 for review and have personally started to go into bug fixing mode. When we reach feature freeze, I think we can still make the following exceptions: 1. C

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/ai_new_wai_files_18042018 into lp:widelands

2018-04-18 Thread TiborB
TiborB has proposed merging lp:~widelands-dev/widelands/ai_new_wai_files_18042018 into lp:widelands. Commit message: Some AI training Requested reviews: Widelands Developers (widelands-dev) For more details, see: https://code.launchpad.net/~widelands-dev/widelands/ai_new_wai_files_18042018/+m

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/django1_11 into lp:widelands-website

2018-04-18 Thread GunChleoc
Review: Approve *waves to SirVer* Can we disallow usernames with "." or "@" in them? Allowing ' would be good, since that character is used in real-world names. I had a look at the diff as far as Launchpad will display it. Just 1 potential nit. Since the alpha site is already switched off, I

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/1733279-ingame-clock into lp:widelands

2018-04-18 Thread GunChleoc
GunChleoc has proposed merging lp:~widelands-dev/widelands/1733279-ingame-clock into lp:widelands. Commit message: Show in-game clock in release builds too. Requested reviews: Widelands Developers (widelands-dev) Related bugs: Bug #1733279 in widelands: "Add in-game clock to release builds"