[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1721121-workers-invisible-wares into lp:widelands

2018-04-14 Thread GunChleoc
The proposal to merge lp:~widelands-dev/widelands/bug-1721121-workers-invisible-wares into lp:widelands has been updated. Commit message changed to: Restored ware hotspot and animation to workers. Made some variables in WorkerDescr private and/or const. For more details, see: https://code.lau

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1721121-workers-invisible-wares into lp:widelands

2018-04-14 Thread GunChleoc
GunChleoc has proposed merging lp:~widelands-dev/widelands/bug-1721121-workers-invisible-wares into lp:widelands. Commit message: Restored ware hotspot to workers. Made some variables in WorkerDescr private and/or const. Requested reviews: Widelands Developers (widelands-dev) Related bugs:

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/smaller_building_statistics into lp:widelands

2018-04-14 Thread Klaus Halfmann
I did some testplaying with a debugger now and gained some coverage of that code: * Everything worked as expected so far. * The Handling of the forward / backward buttons has room for improvement: * no need so use large switch blocks -> call the repective function directly. * Maybe I can do

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/string-fixes into lp:widelands

2018-04-14 Thread Benedikt Straub
Review: Approve Proofread the changes, everything looks good to me. Tested the in-game help and played a quick artifacts game; it all works as it should. -- https://code.launchpad.net/~widelands-dev/widelands/string-fixes/+merge/342037 Your team Widelands Developers is subscribed to branch lp:~