Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/net-boost-asio into lp:widelands

2017-05-29 Thread Notabilis
Travis is only complaining about my coding style, which I have to agree with. The current apple-test-code is totally ugly. ;-) The failing builds are the debug builds, seems like release builds aren't doing codechecks. When I understood it right, the new code worked on your system, or? If you wa

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1687100-reveal_fields into lp:widelands

2017-05-29 Thread kaputtnik
> do you want that switched off? Lets say: If it doesn't make much work it would be fine to have the possibility to switch that off :-) Otherwise i could live with the current state. The bug with the disappearing census and statistics is gone now. Thank you very much for working on this. You c

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/weaver_spins_gold into lp:widelands

2017-05-29 Thread GunChleoc
This is breaking savegame compatibility and writing good code for that takes more time than I'm willing to invest right now. Postponed to after Build 20. -- https://code.launchpad.net/~widelands-dev/widelands/weaver_spins_gold/+merge/324692 Your team Widelands Developers is requested to review th

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/weaver_spins_gold into lp:widelands

2017-05-29 Thread GunChleoc
The proposal to merge lp:~widelands-dev/widelands/weaver_spins_gold into lp:widelands has been updated. Status: Needs review => Work in progress For more details, see: https://code.launchpad.net/~widelands-dev/widelands/weaver_spins_gold/+merge/324692 -- Your team Widelands Developers is re

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/net-boost-asio into lp:widelands

2017-05-29 Thread Klaus Halfmann
Codecheck from travis fails, but for some compilers? grep '^[/_.a-zA-Z]\+:[0-9]\+:' codecheck.out /home/travis/build/widelands/widelands/src/network/network_lan_promotion.cc:225: Use log() from base/log.h instead of printf. /home/travis/build/widelands/widelands/src/network/network_lan_promotion

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1687100-reveal_fields into lp:widelands

2017-05-29 Thread GunChleoc
I guess the bug in the military scenario is that the soldiers see where they are going - do you want that switched off? -- https://code.launchpad.net/~widelands-dev/widelands/bug-1687100-reveal_fields/+merge/323721 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/wideland