Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/net-boost-asio into lp:widelands

2017-05-23 Thread Notabilis
Seems like its building on Windows (or at least on Appveyor) now. A confirmation and a short test would be appreciated, though. Also, building and testing on MacOS is still missing. -- https://code.launchpad.net/~widelands-dev/widelands/net-boost-asio/+merge/324364 Your team Widelands Developers

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/net-boost-asio into lp:widelands

2017-05-23 Thread bunnybot
Continuous integration builds have changed state: Travis build 2241. State: passed. Details: https://travis-ci.org/widelands/widelands/builds/235398138. Appveyor build 2076. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_net_boost_

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/fh1-multitexture into lp:widelands

2017-05-23 Thread GunChleoc
> Do you have a chache hit ratio computed somewhere? No, I just used the log output to experiment a bit to find an acceptable value. Since we have 2 caches now, I made one really big while testing the other and vice versa. BTW the gametime being kicked out is perfectly OK, since it counts up, s

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/fh1-multitexture into lp:widelands

2017-05-23 Thread GunChleoc
Thanks for the review! I have hopefully fixed the compiler warnings now - we'll just have to wait what clang says. I also addressed your points from a few posts up and added some more documentation to the RendererText header file - I hope it will make the code a bit more clear. Yes, it's a bit

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/fh1-multitexture into lp:widelands

2017-05-23 Thread Klaus Halfmann
I got some compile warning we should not neglect: fh1-multitexture/src/graphic/text/transient_cache.h:48:2: warning: 'TransientCache' has virtual functions but non-virtual destructor [-Wnon-virtual-dtor] ~TransientCache(); in general when subclassing and using a parent pointer the

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1687100-reveal_fields into lp:widelands

2017-05-23 Thread kaputtnik
Sorry, wrong alert :S I accidentally edited the seafaring tutorial in trunk ... So trunk does NOT show this behavior. Seems i must limit the things i am working on... Sorry for the noise. -- https://code.launchpad.net/~widelands-dev/widelands/bug-1687100-reveal_fields/+merge/323721 Your team Wi

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1687100-reveal_fields into lp:widelands

2017-05-23 Thread kaputtnik
I have just seen that the mentioned behavior (disappearing census and statistics) do also happen in current trunk when playing the seafaring tutorial. I check this in build 19... (must first compile from scratch) -- https://code.launchpad.net/~widelands-dev/widelands/bug-1687100-reveal_fields/+m

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/fh1-multitexture into lp:widelands

2017-05-23 Thread GunChleoc
The proposal to merge lp:~widelands-dev/widelands/fh1-multitexture into lp:widelands has been updated. Commit Message changed to: The new font renderer now creates a set of textures that will be blitted separately by the new class RenderedText. This avoids issues with texture sizes exceeding t

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/fh1-multitexture into lp:widelands

2017-05-23 Thread GunChleoc
I have now removed all the temporary testing stuff, so the compiler warning and the "TransientCache: Dropping" output should be gone now. I have only commented out the log output in "graphic/text/transient_cache.h", so it can easily be activated again for further tweaking of the cache size. >Fr