The proposal to merge
lp:~widelands-dev/widelands/bug-1691335-network-empty-map-wincondition into
lp:widelands has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/bug-1691335-network-empty-map-wincondition/+merge/324160
Thanks for the review :)
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/changelog_bzr8352/+merge/324158
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/changelog_bzr8352.
___
Mailing list: htt
Thanks for the review :)
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1691335-network-empty-map-wincondition/+merge/324160
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1691335-network-empty-map-wincondition.
___
Review: Approve
Great progress :-)
Two nits, otherwise LGTM.
Diff comments:
> === modified file 'ChangeLog'
> --- ChangeLog 2016-11-05 09:38:59 +
> +++ ChangeLog 2017-05-17 08:08:26 +
> @@ -1,5 +1,208 @@
> -## Build 19-rc1
> -
> +## Post Build 19 until bzr8352
> +
> +### Animations, Ico
Review: Approve
Code looks good and I wasn't able to make it crash any longer.
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1691335-network-empty-map-wincondition/+merge/324160
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1691335-network-em
Mhh, I will need to attach a debbuger to track this down and the
next week are packed with stuff we should do, sigh.
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1690519-playercolor/+merge/324053
Your team Widelands Developers is requested to review the proposed merge of
lp:~widela
Continuous integration builds have changed state:
Travis build 2203. State: passed. Details:
https://travis-ci.org/widelands/widelands/builds/233164848.
Appveyor build 2038. State: success. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_bug_169133
Now I'm confused. Why on Earth do the multiplayer settings have anything to do
with an editor tool?
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1690519-playercolor/+merge/324053
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands
Continuous integration builds have changed state:
Travis build 2202. State: passed. Details:
https://travis-ci.org/widelands/widelands/builds/233144292.
Appveyor build 2037. State: success. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_changelog_
GunChleoc has proposed merging
lp:~widelands-dev/widelands/bug-1691335-network-empty-map-wincondition into
lp:widelands.
Commit message:
Fixed crash in multiplayer client when the host hasn't selected a map yet.
- Catch exception when server sends a garbage win condition and display an
error me
GunChleoc has proposed merging lp:~widelands-dev/widelands/changelog_bzr8352
into lp:widelands.
Commit message:
Updated changelog up to bzr8352.
Requested reviews:
Widelands Developers (widelands-dev)
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/changelog_bzr8352
11 matches
Mail list logo
